move shellcheck to bash script; use git ls-files to ignore gitignored…#2380
Merged
move shellcheck to bash script; use git ls-files to ignore gitignored…#2380
Conversation
… files from being caught in shellcheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… files from being caught in shellcheck
As a follow-up to #2361 instead of "shell find" could we use
git ls-fileshere actually? If I have built libzauth locally, or other things in gitignore, it trips the various shell scripts inside those subfolders locally, even though they are gitignored.This PR makes use of git ls-files and moves the logic from Makefile to a shell script, as the array magic inside Makefile is a bit weird to deal with I find.