Merged
Conversation
5 tasks
14636cb to
c82b437
Compare
c82b437 to
2772e85
Compare
akshaymankar
approved these changes
May 5, 2022
Member
akshaymankar
left a comment
There was a problem hiding this comment.
We should create issues to fix the ignored scripts if we really want to do the FUTUREWORK.
Approving since this is still an improvement.
stephen-smith
approved these changes
May 5, 2022
2772e85 to
e45d7e4
Compare
Contributor
Author
|
@akshaymankar , Good idea 👍 I've created tasks/tickets for the ignored files: https://wearezeta.atlassian.net/browse/SQPIT-952 |
It lints all shell scripts that are not excluded, i.e. new ones and old ones without issues. Excluded are those that currently have issues. They should be fixed on a step-by-step basis. This conservative/careful approach is necessary due to shell scripts having neither a type checker nor tests. "Surprises" should be avoided, especially as they might appear in stressful situations.
e45d7e4 to
109356b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It lints all shell scripts that are not excluded, i.e. new ones and old ones without issues. Excluded are those that currently have issues. They should be fixed on a step-by-step basis. This conservative/careful approach is necessary due to shell scripts having neither a type checker nor tests. "Surprises" should be avoided, especially as they might
appear in stressful situations.
This PR supersedes #2310 . In that PR I learned that even simple looking quotes may lead to awful errors.
https://wearezeta.atlassian.net/browse/SQPIT-279
Checklist
schema`** to update the cassandra schema documentation.
changelog.d.