Servantify cargohold and add federationDomain option#1990
Servantify cargohold and add federationDomain option#1990pcapriotti merged 26 commits intodevelopfrom
federationDomain option#1990Conversation
96b01b8 to
627c643
Compare
f34ebcf to
7d40012
Compare
jschaul
left a comment
There was a problem hiding this comment.
Approving the federationDomain setting option in its various incantations. The rest I just skimmed.
fisx
left a comment
There was a problem hiding this comment.
Could you rebase this so it doesn't contain other PRs any more?
There was a problem hiding this comment.
this doesn't match the title of the PR.
There was a problem hiding this comment.
True, but it would be somewhat painful to split this into two PR, since the ZAuth servant combinators have integration with the Qualified stuff that needs knowledge of the federation domain, which we'll need in cargohold later anyway. It would just be more pointless work to do this in two steps.
Can I just expand the PR description to include this?
There was a problem hiding this comment.
I updated the title and description. Ok to merge?
Thanks @isovector for suggesting this approach.
Co-authored-by: jschaul <jschaul@users.noreply.github.com>
678ade3 to
64e0bf7
Compare
Done. The unrelated schema changes are now gone. |
federationDomain option
This converts the public API to Servant, removes the dependency on wai-routing, and also introduces a mandatory
federationDomainconfiguration option.Tracked by https://wearezeta.atlassian.net/browse/SQCORE-1174.
Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.