Conversation
pcapriotti
force-pushed
the
cargohold-federated-api
branch
from
2ecba91 to
bb56ba6
Compare
pcapriotti
force-pushed
the
pcapriotti/cargohold-servant
branch
from
678ade3 to
64e0bf7
Compare
pcapriotti
force-pushed
the
cargohold-federated-api
branch
from
bb56ba6 to
7ee0ec9
Compare
pcapriotti
force-pushed
the
cargohold-federated-api
branch
from
900d2b1 to
a810c76
Compare
mdimjasevic
reviewed
Dec 23, 2021
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
I'll continue later with reviewing. Some smaller comments are inlined.
Note that streaming is not yet supported for the client. Therefore, when a client for an endpoint that includes a streaming response is invoked, and a streaming response is received, the client will just fail.
Also make `AssetLocation` type more high level.
supersven
force-pushed
the
cargohold-federated-api
branch
from
a810c76 to
31f2de4
Compare
mdimjasevic
approved these changes
Dec 27, 2021
…constraint The HasCallStack constraint leads to more descriptive stacktraces. The new name reflects better, that this function may fail/throw.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the asset API federation-aware. This is accomplished by creating qualified endpoints for downloading and deleting assets, as well as returning the local domain as part of the response object on upload.
Federated behaviour is not yet implemented, but the new endpoints can already be used just like the old ones for local assets (i.e. when the domain is the local one).
Tracked by https://wearezeta.atlassian.net/browse/FS-306
Checklist
changelog.d.