Conversation
fisx
requested changes
Dec 9, 2021
Contributor
fisx
left a comment
There was a problem hiding this comment.
Both this and #1976 look great, but please add integration tests.
- - add code (i think?)
- not so sure where
getis called? - I also just realized that if a conversation is created, there is the option of adding a guest link right away. That should also trigger the same error (can be done here or in a separate PR; I'll add it to the ticket.)
changelog.d/2-features/pr-1980
Outdated
| @@ -0,0 +1 @@ | |||
| If guest links team feature is disabled `post /conversations/:cnv/code` and `get /conversations/:cnv/code` will return an error. | |||
Contributor
There was a problem hiding this comment.
I'm thinking what would be the right level of aggregation here? Maybe keep this but start with "enforce disabled conv links."?
66e60ca to
8d4fdc1
Compare
Base automatically changed from
SQSERVICES-547-enforce-disabling-guest-links-feature
to
develop
December 17, 2021 16:26
changelog addCode: return error if feature disabled changelog check feature enabled for get code
ab0fae3 to
cf7294a
Compare
fisx
approved these changes
Dec 20, 2021
Contributor
fisx
left a comment
There was a problem hiding this comment.
LGTM! (I probably would have tried to eliminate code duplication in the two tests, but this also works.)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1057
Checklist
If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.If a cassandra schema migration has been added, I ranmake git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.If new config options introduced: added usage description under docs/reference/config-options.mdIf new config options introduced: recommended measures to be taken by on-premise instance operators.If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.If public end-points have been changed or added: does nginz need un upgrade?If internal end-points have been added or changed: which services have to be deployed in a specific order?