Skip to content

Comments

SQSERVICES-547 Enforce disabling guest links when conversation is joined#1976

Merged
battermann merged 9 commits intodevelopfrom
SQSERVICES-547-enforce-disabling-guest-links-feature
Dec 17, 2021
Merged

SQSERVICES-547 Enforce disabling guest links when conversation is joined#1976
battermann merged 9 commits intodevelopfrom
SQSERVICES-547-enforce-disabling-guest-links-feature

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Dec 8, 2021

https://wearezeta.atlassian.net/browse/SQSERVICES-1057

This PR handles only conversations/join

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@battermann battermann force-pushed the SQSERVICES-547-enforce-disabling-guest-links-feature branch 2 times, most recently from e038868 to 4d801cf Compare December 8, 2021 16:28
@battermann battermann force-pushed the SQSERVICES-547-add-feature-config-for-guest-links branch from 5c867e4 to 7fd8eb2 Compare December 9, 2021 10:22
@battermann battermann changed the title SQSERVICES-547 Enforce Disabling Guest Link Feature SQSERVICES-547 Enforce disabling guest links when conversation is joined Dec 9, 2021
@battermann battermann force-pushed the SQSERVICES-547-enforce-disabling-guest-links-feature branch from dcf1282 to 392d1fa Compare December 9, 2021 11:40
Base automatically changed from SQSERVICES-547-add-feature-config-for-guest-links to develop December 9, 2021 11:42
@battermann battermann force-pushed the SQSERVICES-547-enforce-disabling-guest-links-feature branch from 392d1fa to 63a20e5 Compare December 9, 2021 11:47
@battermann battermann marked this pull request as ready for review December 9, 2021 12:09
@battermann battermann requested a review from fisx December 9, 2021 12:09
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we need an integration test for this.

@fisx
Copy link
Contributor

fisx commented Dec 9, 2021

Yes, I think we need an integration test for this.

you can probably add it here:

test s "get code-access conversation information" testJoinCodeConv,

@battermann battermann force-pushed the SQSERVICES-547-enforce-disabling-guest-links-feature branch from 4a21af9 to 66e60ca Compare December 10, 2021 12:52
@fisx fisx changed the title SQSERVICES-547 Enforce disabling guest links when conversation is joined SQSERVICES-547 Enforce disabling guest links when conversation is joined [skip ci] Dec 17, 2021
@fisx fisx force-pushed the SQSERVICES-547-enforce-disabling-guest-links-feature branch from 66e60ca to 8d4fdc1 Compare December 17, 2021 10:30
@fisx fisx changed the title SQSERVICES-547 Enforce disabling guest links when conversation is joined [skip ci] SQSERVICES-547 Enforce disabling guest links when conversation is joined Dec 17, 2021
@battermann battermann merged commit f99f1e4 into develop Dec 17, 2021
@battermann battermann deleted the SQSERVICES-547-enforce-disabling-guest-links-feature branch December 17, 2021 16:26
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants