Skip to content

Comments

Fix assertion after #1956#1978

Merged
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/federator-cargohold-fix
Dec 9, 2021
Merged

Fix assertion after #1956#1978
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/federator-cargohold-fix

Conversation

@pcapriotti
Copy link
Contributor

Fix failing test on develop caused by merging #1956 and #1973.

No CHANGELOG entry.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

@fisx
Copy link
Contributor

fisx commented Dec 9, 2021

No CHANGELOG entry.

Again, release notes would be more correct if the release notes entries for the old PR would contain both PRs in brackets now.

@fisx
Copy link
Contributor

fisx commented Dec 9, 2021

    RealAWS
      resumable
        small:              OK (0.03s)
        large:              FAIL (1.52s)
          test/integration/API/V3.hs:380:
          status
          expected: Status {statusCode = 204, statusMessage = "No Content"}
           but got: Status {statusCode = 500, statusMessage = "Internal Server Error"}

not sure if that's related. i'll run this again!

@pcapriotti
Copy link
Contributor Author

Again, release notes would be more correct if the release notes entries for the old PR would contain both PRs in brackets now.

Done on both PRs, but of course they'll conflict with each other.

@pcapriotti
Copy link
Contributor Author

    RealAWS
      resumable
        small:              OK (0.03s)
        large:              FAIL (1.52s)
          test/integration/API/V3.hs:380:
          status
          expected: Status {statusCode = 204, statusMessage = "No Content"}
           but got: Status {statusCode = 500, statusMessage = "Internal Server Error"}

not sure if that's related. i'll run this again!

This is a flake that has appeared recently. I don't know if it's related to the recent changes to cargohold. Seems unlikely.

@pcapriotti pcapriotti merged commit fbeb933 into develop Dec 9, 2021
@pcapriotti pcapriotti deleted the pcapriotti/federator-cargohold-fix branch December 9, 2021 10:06
@sysvinit sysvinit mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants