Merged
Conversation
Contributor
Again, release notes would be more correct if the release notes entries for the old PR would contain both PRs in brackets now. |
fisx
approved these changes
Dec 9, 2021
Contributor
not sure if that's related. i'll run this again! |
Contributor
Author
Done on both PRs, but of course they'll conflict with each other. |
Contributor
Author
This is a flake that has appeared recently. I don't know if it's related to the recent changes to cargohold. Seems unlikely. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failing test on develop caused by merging #1956 and #1973.
No CHANGELOG entry.
Checklist