Add federation component for Cargohold#1973
Merged
pcapriotti merged 5 commits intodevelopfrom Dec 8, 2021
Merged
Conversation
jschaul
approved these changes
Dec 7, 2021
Member
jschaul
left a comment
There was a problem hiding this comment.
CI seems to not have been able to install things for this PR (I retriggered CI); but the changeset looks good.
jschaul
reviewed
Dec 7, 2021
| port: 8082 | ||
| cargohold: | ||
| host: 0.0.0.0 | ||
| port: 8084 |
Member
There was a problem hiding this comment.
This block also needs to be added to the similar place under charts/federator/ for CI to pass.
7044a9a to
c4bf050
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply adds Cargohold as a new federated component in Federator, and a federated API stub in Cargohold itself.
Note: this contains the first few commits from #1966.
Checklist
changelog.d.