Skip to content

Comments

Add federation component for Cargohold#1973

Merged
pcapriotti merged 5 commits intodevelopfrom
pcapriotti/cargohold-component
Dec 8, 2021
Merged

Add federation component for Cargohold#1973
pcapriotti merged 5 commits intodevelopfrom
pcapriotti/cargohold-component

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Dec 7, 2021

This PR simply adds Cargohold as a new federated component in Federator, and a federated API stub in Cargohold itself.

Note: this contains the first few commits from #1966.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti mentioned this pull request Dec 7, 2021
4 tasks
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to not have been able to install things for this PR (I retriggered CI); but the changeset looks good.

port: 8082
cargohold:
host: 0.0.0.0
port: 8084
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block also needs to be added to the similar place under charts/federator/ for CI to pass.

@jschaul jschaul force-pushed the pcapriotti/cargohold-component branch from 7044a9a to c4bf050 Compare December 7, 2021 23:53
@pcapriotti pcapriotti merged commit 067e21c into develop Dec 8, 2021
@pcapriotti pcapriotti deleted the pcapriotti/cargohold-component branch December 8, 2021 06:56
@fisx fisx mentioned this pull request Dec 8, 2021
2 tasks
@pcapriotti pcapriotti mentioned this pull request Dec 9, 2021
2 tasks
@sysvinit sysvinit mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants