-
Notifications
You must be signed in to change notification settings - Fork 332
Provide ormolu via direnv, run make formatc in github actions
#1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
43dcffa
nix: add ormolu to wire-server-direnv
flokli 88aab94
direnv.nix: nixpkgs-fmt
flokli efa73cc
.github/workflows: add ci.yml
flokli bb7b7db
.github/workflows/ci.yml: run make formatc
flokli 56e6e61
tools/ormolu.sh: use utf-8 for IO
flokli e42d91a
changelog: add changelog
flokli 682a130
Hi CI
jschaul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [master] | ||
|
|
||
| jobs: | ||
| build-dev-env: | ||
| name: Build dev env | ||
| strategy: | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest | ||
| # This is too expensive | ||
| # - macos-latest | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| submodules: true | ||
| - uses: cachix/install-nix-action@v14.1 | ||
| - uses: cachix/cachix-action@v10 | ||
| with: | ||
| name: wire-server | ||
| signingKey: '${{ secrets.CACHIX_SIGNING_KEY }}' | ||
| authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}' | ||
| - name: Build the wire-server-direnv | ||
| run: nix-build --no-out-link direnv.nix | ||
| - name: Install the wire-server-direnv | ||
| run: nix-env -f direnv.nix -i | ||
| - name: Ensure everything is formatted | ||
| run: make formatc | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add ormolu to the direnv, add a GH Action to ensure formatting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a concourse check for the formatc thing; so these last two lines are not really necessary I'd say; but sure we can have the check run twice in case one CI is down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concourse CI Logs aren't visible externally, and in the past, they were red for quite some time without getting fixed. Having CI definitons in the same repo, and public readable logs allows everyone to send a PR to fix it.
It'd be pretty simple to require that gh actions pipeline to be green before merging. Adding a separate concourse pipeline only for that purpose would be much more involved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ormolu check from concourse is behaving just fine and hasn't had any problems I'm aware of. As for the "visible logs for externals", there is a believe an ongoing project for a concourse-on-k8s-for-CI from the PIT team that would solve that part, but not just for ormolu, but also for all the other checks that currently run on CI.
I already approved the PR so I'm not against adding this check a second time, it's just providing little extra value at this point IMO.