Provide ormolu via direnv, run make formatc in github actions#1908
Provide ormolu via direnv, run make formatc in github actions#1908
make formatc in github actions#1908Conversation
This builds the direnv, so it's available in the cachix binary cache.
This ensures the codebase is properly formatted.
020e84a to
08b2023
Compare
jschaul
left a comment
There was a problem hiding this comment.
Could you add a changelog line under changelog.d/5-internal/ ?
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
We already have a concourse check for the formatc thing; so these last two lines are not really necessary I'd say; but sure we can have the check run twice in case one CI is down.
There was a problem hiding this comment.
Concourse CI Logs aren't visible externally, and in the past, they were red for quite some time without getting fixed. Having CI definitons in the same repo, and public readable logs allows everyone to send a PR to fix it.
It'd be pretty simple to require that gh actions pipeline to be green before merging. Adding a separate concourse pipeline only for that purpose would be much more involved.
There was a problem hiding this comment.
The ormolu check from concourse is behaving just fine and hasn't had any problems I'm aware of. As for the "visible logs for externals", there is a believe an ongoing project for a concourse-on-k8s-for-CI from the PIT team that would solve that part, but not just for ormolu, but also for all the other checks that currently run on CI.
I already approved the PR so I'm not against adding this check a second time, it's just providing little extra value at this point IMO.
|
I added the changelog entry. PTAL. |
Otherwise, ormolu fails with some locales on non-ASCII characters: ``` ormolu: libs/dns-util/src/Wire/Network/DNS/SRV.hs: hGetContents: invalid argument (invalid byte sequence) ``` See tweag/ormolu#38 and https://gitlab.haskell.org/ghc/ghc/-/issues/17755 for details.
aca15a1 to
e42d91a
Compare
This will provide ormolu via direnv, and do some CI steps in GH Actions:
make formatcand provide feedback if code is not formatted.Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.