Merged
Conversation
4 tasks
4965697 to
9b65a81
Compare
mdimjasevic
approved these changes
Nov 4, 2021
Contributor
mdimjasevic
left a comment
There was a problem hiding this comment.
Should grepping for "Cassandra" in the Galley/Data directory yield any import Cassandra lines? This is what I got by running ag "import Cassandra":
Scope.hs
22:import Cassandra hiding (Value)
Instances.hs
26:import Cassandra.CQL
ResultSet.hs
20:import Cassandra
Access.hs
20:import Cassandra
Queries.hs
23:import Cassandra as C hiding (Value)
24:import Cassandra.Util (Writetime)
Conversation.hs
35:import Cassandra
Contributor
Author
|
I moved all the Cassandra-specific stuff out of Data. Unfortunately, some modules are still importing Cassandra modules directly, mostly for the paging stuff. |
This removes the `MonadClient` instance from `Galley`, and therefore makes all the DB-related code go through one of the store effects.
1446a25 to
539d109
Compare
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #1890, and part of step 2 of the polysemy refactoring series. It removes the
MonadClientinstance fromGalley, and therefore makes all the DB-related code go through one of the store effects.New effects:
CustomBackendStoreLegalHoldStoreSearchVisibilityStoreTeamFeatureStoreTeamNotificationStoreChecklist
changelog.d.