Skip to content

Implement all other store effects#1906

Merged
pcapriotti merged 9 commits intodevelopfrom
pcapriotti/galley-store-effects2
Nov 5, 2021
Merged

Implement all other store effects#1906
pcapriotti merged 9 commits intodevelopfrom
pcapriotti/galley-store-effects2

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Nov 3, 2021

This is a followup to #1890, and part of step 2 of the polysemy refactoring series. It removes the MonadClient instance from Galley, and therefore makes all the DB-related code go through one of the store effects.

New effects:

  • CustomBackendStore
  • LegalHoldStore
  • SearchVisibilityStore
  • TeamFeatureStore
  • TeamNotificationStore

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Base automatically changed from pcapriotti/galley-placeholders to develop November 4, 2021 05:28
@pcapriotti pcapriotti force-pushed the pcapriotti/galley-store-effects2 branch from 4965697 to 9b65a81 Compare November 4, 2021 05:33
@pcapriotti pcapriotti marked this pull request as ready for review November 4, 2021 05:34
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should grepping for "Cassandra" in the Galley/Data directory yield any import Cassandra lines? This is what I got by running ag "import Cassandra":

Scope.hs
22:import Cassandra hiding (Value)

Instances.hs
26:import Cassandra.CQL

ResultSet.hs
20:import Cassandra

Access.hs
20:import Cassandra

Queries.hs
23:import Cassandra as C hiding (Value)
24:import Cassandra.Util (Writetime)

Conversation.hs
35:import Cassandra

@pcapriotti
Copy link
Contributor Author

I moved all the Cassandra-specific stuff out of Data. Unfortunately, some modules are still importing Cassandra modules directly, mostly for the paging stuff.

@pcapriotti pcapriotti force-pushed the pcapriotti/galley-store-effects2 branch from 1446a25 to 539d109 Compare November 4, 2021 13:53
@pcapriotti pcapriotti merged commit 87c27d3 into develop Nov 5, 2021
@pcapriotti pcapriotti deleted the pcapriotti/galley-store-effects2 branch November 5, 2021 12:26
@akshaymankar akshaymankar mentioned this pull request Nov 15, 2021
@smatting smatting mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants