Skip to content

Comments

Galley polysemy (3/5) - Access effects#1904

Merged
pcapriotti merged 7 commits intodevelopfrom
pcapriotti/galley-placeholders
Nov 4, 2021
Merged

Galley polysemy (3/5) - Access effects#1904
pcapriotti merged 7 commits intodevelopfrom
pcapriotti/galley-placeholders

Conversation

@pcapriotti
Copy link
Contributor

This PR turns placeholder access effect for internal APIs and external services into actual Polysemy effects.

Summary

  • Implemented effects:
    • BrigAccess
    • BotAccess
    • SparAccess
    • GundeckAccess
    • ExternalAccess
    • FederatorAccess
  • Removed placeholder Intra effect

Overall plan for the Polysemy refactoring of Galley

  1. Turn Galley into a newtype over Sem, and introduce "access" effects.
  2. Add "store" effects and convert Data code into interpretations.
  3. Turn placeholders into actual effects. (this pr)
  4. Add fine-grained Error effects, and integrate them with Servant.
  5. Make Galley into a type synonym over Sem, and get rid of Galley0.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti marked this pull request as ready for review November 2, 2021 16:38
@pcapriotti pcapriotti marked this pull request as draft November 2, 2021 16:52
@pcapriotti pcapriotti marked this pull request as ready for review November 2, 2021 17:11
@pcapriotti pcapriotti force-pushed the pcapriotti/galley-placeholders branch from 31db8b3 to e56a756 Compare November 3, 2021 06:28
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. A few comments are inlined.

@pcapriotti pcapriotti merged commit 6ba5bec into develop Nov 4, 2021
@pcapriotti pcapriotti deleted the pcapriotti/galley-placeholders branch November 4, 2021 05:28
@akshaymankar akshaymankar mentioned this pull request Nov 15, 2021
@smatting smatting mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants