Revert hack to display helm test output#1742
Merged
pcapriotti merged 1 commit intodevelopfrom Sep 8, 2021
Merged
Conversation
The hack in #1700 does not actually seem to work in CI, and in fact it prevents log output from being displayed at all when helm test fails. The integration-test-logs.sh script is still around, and it can be used to display helm test output interactive when running tests manually in a terminal.
akshaymankar
approved these changes
Sep 8, 2021
This was referenced Sep 8, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hack in #1700 does not actually seem to work in CI, and in fact it prevents log output from being displayed at all when helm test fails.
The
integration-test-logs.shscript is still around, and it can be used to displayhelm testoutput interactive when running tests manually in a terminal.No CHANGELOG entry.
Checklist