Display helm test logs interactively#1700
Merged
akshaymankar merged 7 commits intodevelopfrom Aug 16, 2021
Merged
Conversation
akshaymankar
approved these changes
Aug 9, 2021
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
Looks good, I am paranoid about bash so I would recommend adding set -euo pipefail everywhere.
Co-authored-by: Akshay Mankar <akshay@wire.com>
pcapriotti
force-pushed
the
pcapriotti/interactive-integration-logs
branch
from
b90e8fd to
ee26624
Compare
pcapriotti
added a commit
that referenced
this pull request
Sep 8, 2021
The hack in #1700 does not actually seem to work in CI, and in fact it prevents log output from being displayed at all when helm test fails. The integration-test-logs.sh script is still around, and it can be used to display helm test output interactive when running tests manually in a terminal.
2 tasks
pcapriotti
added a commit
that referenced
this pull request
Sep 8, 2021
The hack in #1700 does not actually seem to work in CI, and in fact it prevents log output from being displayed at all when helm test fails. The integration-test-logs.sh script is still around, and it can be used to display helm test output interactive when running tests manually in a terminal.
Merged
pcapriotti
added a commit
that referenced
this pull request
Sep 8, 2021
The hack in #1700 does not actually seem to work in CI, and in fact it prevents log output from being displayed at all when helm test fails. The integration-test-logs.sh script is still around, and it can be used to display helm test output interactive when running tests manually in a terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
kubectl logs -fto display test output while integration tests are running.Checklist