Merged
Conversation
The hack in #1700 does not actually seem to work in CI, and in fact it prevents log output from being displayed at all when helm test fails. The integration-test-logs.sh script is still around, and it can be used to display helm test output interactive when running tests manually in a terminal.
mdimjasevic
approved these changes
Sep 8, 2021
Comment on lines
2429
to
2430
| putQualifiedConversationName (qUnqualified qbob) qconv "gossip" | ||
| !!! const 404 === statusCode |
Contributor
There was a problem hiding this comment.
Just nitpicking: how about asserting on a label too?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the conversation rename endpoints to Servant, makes them deprecated, and adds a qualified endpoint for renaming a conversation. The qualified endpoint still only works for local conversations.
I also added some tests for both deprecated endpoints and the qualified endpoint, and a failing test for the qualified endpoint.
No new nginx routes are needed.
Checklist