Add helm charts and config for prometheus monitoring#36
Merged
ChrisPenner merged 2 commits intomasterfrom Apr 8, 2019
Merged
Conversation
ChrisPenner
commented
Apr 3, 2019
ChrisPenner
commented
Apr 3, 2019
| options: | ||
| path: /var/lib/grafana/dashboards/default | ||
|
|
||
| # TODO: Chart importing is broken for the time being; should be fixed in |
Contributor
Author
There was a problem hiding this comment.
I created an issue which references this; I'd prefer to merge through without dashboard importing for now since it'll be easiest to wait a week or two for the fix to make it downstream.
jschaul
reviewed
Apr 3, 2019
d3b8b09 to
149a766
Compare
jschaul
approved these changes
Apr 4, 2019
Member
jschaul
left a comment
There was a problem hiding this comment.
A few more minor comments about the docs, otherwise looks perfect!
6ab4c4d to
8d111ea
Compare
8d111ea to
54ae4e8
Compare
Collaborator
|
{"pr":"36","commit":"54ae4e8268eb53329b2f6273cf24e12070d58600","committed":"2019-04-08T10:20:18Z"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state doesn't bundle in graphs for wire-services, I've pulled that out as a separate issue since it will likely be easier if we wait a week or two for the grafana dashboard importing fix to make its way downstream: #38
Once helm/helm#5112 is merged we may be able to simplify the installation path a bit.