Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885 🍒 #2902

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 25, 2024

BugWPB-9774 Refactoring MLS Client Identity models

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

To fetch the MLSClientIdentity from CC we were mapping them in different models, due to different changes we needed more data to be exposed, we needed them to be unified and map all the available data from CC.

Issues

Hard to maintain different models
Due to maturity of CC now we have a rich and solid model we can map full object in Kalium and Android App.

Needs releases with:
With AR

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

All E2EI features must work as before!


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

* chore: refactor identity models

* fix tests

* user correct clientId and Handle in MLSClientIdentity object

* clean mapping object checker

* fix formatting and remove one line un-used code

---------

Co-authored-by: Vitor Hugo Schwaab <[email protected]>

(cherry picked from commit 8f000c0)
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: technical-debt Changes intended at mitigating risks type: chore 🧹 👕 size: XL 🚨 Potential breaking changes labels Jul 25, 2024
Copy link

sonarcloud bot commented Jul 25, 2024

Copy link
Contributor Author

github-actions bot commented Jul 25, 2024

Test Results

3 134 tests  +1   3 029 ✔️ +1   3m 10s ⏱️ -16s
   538 suites ±0      105 💤 ±0 
   538 files   ±0          0 ±0 

Results for commit 6cf77b1. ± Comparison against base commit e695d63.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
com.wire.kalium.logic.feature.e2ei.GetE2eiCertificateUseCaseTest ‑ givenRepositoryReturnsNullCertificate_whenRunningUseCase_thenReturnNotActivated[jvm]
com.wire.kalium.logic.feature.e2ei.GetE2eiCertificateUseCaseTest ‑ givenRepositoryReturnsBasicClient_whenRunningUseCase_thenReturnNotActivatedStatus[jvm]
com.wire.kalium.logic.feature.e2ei.GetE2eiCertificateUseCaseTest ‑ givenRepositoryReturnsNullCertificate_whenRunningUseCase_thenReturnFailure[jvm]

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

🐰Bencher

ReportThu, July 25, 2024 at 17:30:59 UTC
Projectkalium
Branchchore/mls/cherry-pick-unify-e2ei-models-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)695,085.96
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)545,147,904.42
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)934,995,685.20
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,428,648.46

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/mls/cherry-pick-unify-e2ei-models-cherry-pick
Commit report: f4c6f80
Test service: kalium-jvm

✅ 0 Failed, 3029 Passed, 105 Skipped, 9.13s Total Time

@mchenani mchenani enabled auto-merge July 26, 2024 08:15
@mchenani mchenani added this pull request to the merge queue Jul 29, 2024
Merged via the queue into develop with commit 206d8fe Jul 29, 2024
22 checks passed
@mchenani mchenani deleted the chore/mls/cherry-pick-unify-e2ei-models-cherry-pick branch July 29, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: technical-debt Changes intended at mitigating risks 🚨 Potential breaking changes 👕 size: XL type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants