-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885 🍒 #2902
chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885 🍒 #2902
Conversation
* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)
Quality Gate passedIssues Measures |
Test Results3 134 tests +1 3 029 ✔️ +1 3m 10s ⏱️ -16s Results for commit 6cf77b1. ± Comparison against base commit e695d63. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Datadog ReportBranch report: ✅ 0 Failed, 3029 Passed, 105 Skipped, 9.13s Total Time |
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
To fetch the MLSClientIdentity from CC we were mapping them in different models, due to different changes we needed more data to be exposed, we needed them to be unified and map all the available data from CC.
Issues
Hard to maintain different models
Due to maturity of CC now we have a rich and solid model we can map full object in Kalium and Android App.
Needs releases with:
With AR
Testing
Test Coverage (Optional)
How to Test
All E2EI features must work as before!
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.