chore(mls): unify MLSClientIdentity models (WPB-9774) 🍒 #2885 #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)
echoes-hq
bot
added
the
echoes: technical-debt
|
borichellow
approved these changes
Jul 25, 2024
Datadog ReportBranch report: ✅ 0 Failed, 3019 Passed, 105 Skipped, 12.18s Total Time |
vitorhugods
approved these changes
Jul 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0)
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
…#2902) * chore: refactor identity models * fix tests * user correct clientId and Handle in MLSClientIdentity object * clean mapping object checker * fix formatting and remove one line un-used code --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> (cherry picked from commit 8f000c0) Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Yamil Medina <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
To fetch the MLSClientIdentity from CC we were mapping them in different models, due to different changes we needed more data to be exposed, we needed them to be unified and map all the available data from CC.
Issues
Hard to maintain different models
Due to maturity of CC now we have a rich and solid model we can map full object in Kalium and Android App.
Needs releases with:
With AR
Testing
Test Coverage (Optional)
How to Test
All E2EI features must work as before!
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.