Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: is user speaking mapper causes a flash briefly (#2809) [WPB-9684] 🍒 #2859

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 2, 2024

BugWPB-9684 Bund has reported a problem with active speaker indication

This PR was automatically cherry-picked based on the following PR:

Original PR description:


(cherry picked from commit 94a64c4)

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

is user speaking mapper causes a flash briefly

Solutions

the condition to decide if a user is speaking atm is

activeSpeaker.audioLevel > 0 && activeSpeaker.audioLevelNow > 0

when it should be

activeSpeaker.audioLevel > 0 || activeSpeaker.audioLevelNow > 0

sice the audioLevelNow can be 0 and cause it to plip whenaudioLevel have a decay

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara enabled auto-merge (squash) July 2, 2024 14:58
Copy link

sonarcloud bot commented Jul 2, 2024

Copy link
Contributor Author

github-actions bot commented Jul 2, 2024

Test Results

3 067 tests   2 962 ✔️  3m 57s ⏱️
   530 suites     105 💤
   530 files           0

Results for commit 39c32b6.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara merged commit 9f768b0 into release/candidate Jul 2, 2024
19 checks passed
@MohamadJaara MohamadJaara deleted the fix/speaking-indecaor-WPB-9684-cherry-pick branch July 2, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants