fix: is user speaking mapper causes a flash briefly

[MohamadJaara]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

is user speaking mapper causes a flash briefly

Solutions

the condition to decide if a user is speaking atm is

activeSpeaker.audioLevel > 0 && activeSpeaker.audioLevelNow > 0

when it should be

activeSpeaker.audioLevel > 0 || activeSpeaker.audioLevelNow > 0

sice the audioLevelNow can be 0 and cause it to plip whenaudioLevel have a decay

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[github-actions]

Test Results

3 070 tests  +3   2 965 ✔️ +3   3m 9s ⏱️ -40s
   531 suites ±0      105 💤 ±0 
   531 files   ±0          0 ❌ ±0 

Results for commit 3730930. ± Comparison against base commit 6b3363f.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.

com.wire.kalium.logic.data.call.ActiveSpeakerMapperTest ‑ givenCallActiveSpeakers_whenMappingToParticipantsActiveSpeaker_thenReturnParticipantsActiveSpeaker[jvm]

com.wire.kalium.logic.data.call.ActiveSpeakerMapperTest ‑ givenUserAudioLevelIs0AndaudioLevelNowIs0_whenMapping_thenUserIsNotSpeaking[jvm]
com.wire.kalium.logic.data.call.ActiveSpeakerMapperTest ‑ givenUserAudioLevelIs0AndaudioLevelNowNot0_whenMapping_thenUserIsSpeaking[jvm]
com.wire.kalium.logic.data.call.ActiveSpeakerMapperTest ‑ givenUserAudioLevelNot0AndaudioLevelNowIs0_whenMapping_thenUserIsSpeaking[jvm]
com.wire.kalium.logic.data.call.ActiveSpeakerMapperTest ‑ givenUserAudioLevelNot0AndaudioLevelNowNot0_whenMapping_thenUserIsSpeaking[jvm]

♻️ This comment has been updated with latest results.

[datadog-wireapp]

Datadog Report

Branch report: fix/active-speaker-indecation
Commit report: e91b894
Test service: kalium-jvm

✅ 0 Failed, 2965 Passed, 105 Skipped, 10.02s Total Time