-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: is user speaking mapper causes a flash briefly #2809
Conversation
Quality Gate passedIssues Measures |
Test Results3 070 tests +3 2 965 ✔️ +3 3m 9s ⏱️ -40s Results for commit 3730930. ± Comparison against base commit 6b3363f. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 2965 Passed, 105 Skipped, 10.02s Total Time |
(cherry picked from commit 94a64c4)
…2859) (cherry picked from commit 94a64c4) Co-authored-by: Mohamad Jaara <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
is user speaking mapper causes a flash briefly
Solutions
the condition to decide if a user is speaking atm is
activeSpeaker.audioLevel > 0 && activeSpeaker.audioLevelNow > 0
when it should be
activeSpeaker.audioLevel > 0 || activeSpeaker.audioLevelNow > 0
sice the audioLevelNow can be 0 and cause it to plip whenaudioLevel have a decay
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.