fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) 🍒 🍒 #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…638) 🍒 (#2838) * Commit with unresolved merge conflicts * resolve conflicts --------- Co-authored-by: Mojtaba Chenani <[email protected]>
github-actions
bot
added
type: bug / fix 🐞
👕 size: S
🚨 Potential breaking changes
labels
vitorhugods
approved these changes
Jun 27, 2024
alexandreferris
approved these changes
Jun 28, 2024
…ation-4.6-cherry-pick-cherry-pick
Datadog ReportBranch report: ✅ 0 Failed, 2988 Passed, 105 Skipped, 11.8s Total Time |
…ation-4.6-cherry-pick-cherry-pick
|
vitorhugods
deleted the
fix/set-correct-cs-when-kalium-start-migration-4.6-cherry-pick-cherry-pick
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
When Android/Kalium starts the migration flow, we actually creating the MLS Conversation, and due to the agreement that the BE will not set the Correct CS in the Create Conversation Response, we need to ignore that value; in the normal conversation creation this was considered, but not in the migration flow.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.