-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) 🍒 #2838
fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) 🍒 #2838
Conversation
…start-migration-4.6-cherry-pick
Datadog ReportBranch report: ✅ 0 Failed, 2955 Passed, 105 Skipped, 12.73s Total Time |
…tart-migration-4.6-cherry-pick' into fix/set-correct-cs-when-kalium-start-migration-4.6-cherry-pick
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2838 +/- ##
====================================================
Coverage ? 58.92%
====================================================
Files ? 1212
Lines ? 47274
Branches ? 4441
====================================================
Hits ? 27857
Misses ? 17404
Partials ? 2013
Continue to review full report in Codecov by Sentry.
|
…638) 🍒 (#2838) * Commit with unresolved merge conflicts * resolve conflicts --------- Co-authored-by: Mojtaba Chenani <[email protected]>
…638) 🍒 (#2838) (#2846) * Commit with unresolved merge conflicts * resolve conflicts --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mojtaba Chenani <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
When Android/Kalium starts the migration flow, we actually creating the MLS Conversation, and due to the agreement that the BE will not set the Correct CS in the Create Conversation Response, we need to ignore that value; in the normal conversation creation this was considered, but not in the migration flow.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.