Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Group call not working when MLS is enabled (WPB-9114) 🍒 #2765

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 14, 2024

BugWPB-9114 [Android] Group calling not working when MLS is enabled

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Group calling not working when MLS is enabled

Causes (Optional)

Caused by: px.c: Field 'cipher_suite' is required for type with serial name 'com.wire.kalium.network.api.base.authenticated.conversation.SubconversationResponse', but it was missing at path: $

cipher_suite argument in ConversationResponse should be optional

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine enabled auto-merge (squash) May 14, 2024 15:16
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor Author

github-actions bot commented May 22, 2024

Test Results

2 910 tests   2 892 ✔️  4m 38s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit d598fe3.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: Group-calling-not-working-when-MLS-is-enabled-cherry-pick
Commit report: f719c2f
Test service: kalium-jvm

❌ 1 Failed (0 Known Flaky), 2906 Passed, 52 Skipped, 9.77s Total Time

❌ Failed Tests (1)

  • givenConversationWithMessages_whenConversationModifiedDateUpdated_thenNotificationNotAffected[jvm] - com.wire.kalium.persistence.dao.message.MessageNotificationsTest - Details

    Expand for error
     app.cash.turbine.TurbineAssertionError: Unconsumed events found:
      - Item([NotificationMessageEntity(id=OTHER_MESSAGE, contentType=TEXT, isSelfDelete=false, [email protected], senderImage=null, date=2022-03-30T15:36:00Z, senderName=otherUser, text=Something to think about, assetMimeType=null, isQuotingSelf=false, [email protected], conversationName=conversation1, mutedStatus=ALL_ALLOWED, conversationType=ONE_ON_ONE)])
     
     app.cash.turbine.TurbineAssertionError: Unconsumed events found:
      - Item([NotificationMessageEntity(id=OTHER_MESSAGE, contentType=TEXT, isSelfDelete=false, [email protected], senderImage=null, date=2022-03-30T15:36:00Z, senderName=otherUser, text=Something to think about, assetMimeType=null, isQuotingSelf=false, [email protected], conversationName=conversation1, mutedStatus=ALL_ALLOWED, conversationType=ONE_ON_ONE)])
     	at app//app.cash.turbine.TurbineAssertionError$Companion.invoke(TurbineAssertionError.kt:32)
     	at app//app.cash.turbine.ChannelTurbine.ensureAllEventsConsumed(Turbine.kt:235)
     	at app//app.cash.turbine.TurbineTestContextImpl.ensureAllEventsConsumed(flow.kt)
     	at app//com.wire.kalium.persistence.dao.message.MessageNotificationsTest$givenConversationWithMessages_whenConversationModifiedDateUpdated_thenNotificationNotAffected$1$1.invokeSuspend(MessageNotificationsTest.kt:74)
     	at app//kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
     ...
    

@ohassine ohassine changed the title fix: Group calling not working when MLS is enabled (WPB-9114) 🍒 fix: Group call not working when MLS is enabled (WPB-9114) 🍒 May 22, 2024
@ohassine ohassine merged commit dcd806b into release/candidate May 22, 2024
21 of 22 checks passed
@ohassine ohassine deleted the Group-calling-not-working-when-MLS-is-enabled-cherry-pick branch May 22, 2024 13:48
github-actions bot added a commit that referenced this pull request May 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
…2781)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Oussama Hassine <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants