-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Group calling not working when MLS is enabled (WPB-9114) #2764
Merged
mchenani
merged 1 commit into
release/android-cycle-4.6
from
Group-calling-not-working-when-MLS-is-enabled
May 14, 2024
Merged
fix: Group calling not working when MLS is enabled (WPB-9114) #2764
mchenani
merged 1 commit into
release/android-cycle-4.6
from
Group-calling-not-working-when-MLS-is-enabled
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreferris
approved these changes
May 14, 2024
ohassine
requested review from
a team,
typfel,
yamilmedina,
borichellow,
MohamadJaara and
vitorhugods
and removed request for
a team
May 14, 2024 14:52
mchenani
approved these changes
May 14, 2024
borichellow
approved these changes
May 14, 2024
8 tasks
ohassine
added a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: Oussama Hassine <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: Oussama Hassine <[email protected]>
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
…2781) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Oussama Hassine <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Group calling not working when MLS is enabled
Causes (Optional)
cipher_suite
argument in ConversationResponse should be optionalNeeds releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.