Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible issue: Node 14 unsupported warning #1797

Closed
1 of 2 tasks
greenhat616 opened this issue May 14, 2020 · 3 comments
Closed
1 of 2 tasks

incompatible issue: Node 14 unsupported warning #1797

greenhat616 opened this issue May 14, 2020 · 3 comments

Comments

@greenhat616
Copy link

greenhat616 commented May 14, 2020

Please tell us about your environment:

  • winston version?
    • winston@3
    • winston@2
  • node -v outputs:
> node -v
v14.2.0
  • Operating System? (Windows, macOS, or Linux) Ubuntu 18.04(wsl 1)
  • Language? (all | TypeScript X.X | ES6/7 | ES5 | Dart) all

What is the problem?

while start program, have a warning showed.
i. node --trace-warnings core.js
ii. show the blow

(node:26972) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:817:11)
    at Object.get (internal/modules/cjs/loader.js:831:5)
    at Object.exports.setLevels (/mnt/d/Programs/Hitokoto_Api/node_modules/winston/lib/winston/common.js:35:14)
    at Object.<anonymous> (/mnt/d/Programs/Hitokoto_Api/node_modules/winston/lib/winston.js:83:8)
    at Module._compile (internal/modules/cjs/loader.js:1176:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10)
    at Module.load (internal/modules/cjs/loader.js:1040:32)
    at Function.Module._load (internal/modules/cjs/loader.js:929:14)
    at Module.require (internal/modules/cjs/loader.js:1080:19)
    at require (internal/modules/cjs/helpers.js:72:18)

What do you expect to happen instead?

with no warning

Other information

@rysenko
Copy link

rysenko commented Jun 18, 2020

Cause it seems like it's not going to be fixed/merged anytime soon and I really don't want to migrate to winston@3, I've created forked npm package - https://www.npmjs.com/package/winston24. This is just [email protected] with fix for this warning applied and bumped to version 2.4.5. Published from this branch: https://github.com/rysenko/winston/commits/2.x

@DABH
Copy link
Contributor

DABH commented Jun 22, 2020

Fixed via #1800 and a 2.4.5 release should be cut shortly. Thanks. Consider upgrading to winston 3 which is maintained and tested against the latest Node versions.

@DABH DABH closed this as completed Jun 22, 2020
LachlanStuart added a commit to metaspace2020/metaspace that referenced this issue Jul 15, 2020
Update webapp babel (via manual lockfile deletion & reinstall) due to babel/babel#11216
Update webapp node-sass for Node 14 support
Update webapp element-ui due to ElemeFE/element#19389
Update graphql bcrypt to hopefully fix rebuild-on-node-version-change behavior
Update graphql knex/pg to fix knex/knex#3836
Update graphql winston to fix winstonjs/winston#1797
Update graphql ts-node-dev to fix wclr/ts-node-dev#143
Pin version of graphql graphql-binding because I remember newer versions not being compatible

Remove hacks needed for node 8 (asyncIterator polyfill, incorrect date format in ElapsedTime.spec.ts)
Updated FilterPanel snapshot. It seems the reason it was reordered was because Array.prototype.sort started using a stable sorting algorithm in Node 11, and `sortFilterKeys` in store/mutations.js sorts against the same value for most items.
LachlanStuart added a commit to metaspace2020/metaspace that referenced this issue Jul 27, 2020
* Upgrade node to v14
Update webapp babel (via manual lockfile deletion & reinstall) due to babel/babel#11216
Update webapp node-sass for Node 14 support
Update webapp element-ui due to ElemeFE/element#19389
Update graphql bcrypt to hopefully fix rebuild-on-node-version-change behavior
Update graphql knex/pg to fix knex/knex#3836
Update graphql winston to fix winstonjs/winston#1797
Update graphql ts-node-dev to fix wclr/ts-node-dev#143
Pin version of graphql graphql-binding because I remember newer versions not being compatible

Remove hacks needed for node 8 (asyncIterator polyfill, incorrect date format in ElapsedTime.spec.ts)
Updated FilterPanel snapshot. It seems the reason it was reordered was because Array.prototype.sort started using a stable sorting algorithm in Node 11, and `sortFilterKeys` in store/mutations.js sorts against the same value for most items.

* Re-enable supervisorctl autorestart

* Debug logging about node versions

* Ansible fixes

* Fix use of nvm in Ansible/Supervisor

* Update CircleCI image for Node 14

* Update graphql lockfile

* Update suggested fix for missing DB schema during provision

* Re-disable sm-cluster-autostart-daemon autorestart

* Make "sm_activate_nvm" variable to simplify nvm use

* Fix after merge
maxcanna added a commit to branch-bookkeeper/ugo that referenced this issue Sep 19, 2020
maxcanna added a commit to branch-bookkeeper/ugo that referenced this issue Sep 19, 2020
maxcanna added a commit to maxcanna/bicineabbiamo that referenced this issue Sep 19, 2020
@rabiaasif
Copy link

I'm still facing this issue, ive updated to @2.4.5 in my node modules and reinstalled, it still crashes but with no warning this time

kellnerd added a commit to kellnerd/bookbrainz-utils that referenced this issue Jun 22, 2023
The old version was causing trouble:
winstonjs/winston#1797
> Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency

https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md
kellnerd added a commit to kellnerd/bookbrainz-utils that referenced this issue Jul 19, 2023
The old version was causing trouble:
winstonjs/winston#1797
> Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency

https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants