-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package is broken with node 14 : fs.watch with recursive is throwing on incompatible os #143
Comments
Same issue here. Thanks for pointing out that the problem is caused by the Node v14. Would never figure out. |
@whitecolor I think we can fix this issue by migrating to chokidar instead of fs.watch. Does it make sense? |
facing the same problem |
Bump - just updated to node v14 and got the same issue. Downgrading to v13 or lower works just fine. Edit: It seems like |
Problem is in underlying Thnx for @onlurking for making fix for it But it seems like filewatcher has not been updated for a while tho, so not sure if it will get merged in there 😞 |
Maybe this project should migrate to chokidar:
|
Will check everything and release it with chokidar soon. |
@whitecolor if you are planning to release a new |
looking forward to the release, right now i'm using a temporary setup with pure nodemon and ts-dev which is at least twice slower to restart |
Hey, while waiting for a fix in To select this specific commit:
|
I am getting this error when using node:alpine when using Docker. SInce I am new to docker would appreciate if someone can assist |
@ssomlk you should Here you can find a list of all the released tags: https://hub.docker.com/_/node/ |
Thanks alot and apreciate ur help @marcoreni |
Run using |
using node v13.14.0 until the fix is merged and works fine |
@mmvsk That fix is pretty nifty, have you submitted it as a pull request yet? |
I just did in PR #149. I'm using For those who want to use this fix right now, before the PR is merged or the underlying issue solved in some other way, you can just install the patched version from my repository:
(and later reinstall the official one, once it's fixed) |
@mmvsk doesn't your PR simply disable recursive watching on linux / node 14? or would it work on linux machines with recursive watching as well (and I am mis-understanding something)? P.S. perhaps using something like this (or another alternative |
Yes, it's precisely what it does. But actually the recursive option never worked on Linux: before Node 14 Actually it "works" on Linux in the same way it was working before Node 14: by using the dependency chain built by the imports. So it's possible to have some missed detections if a file is modified in a deep directory without being imported anywhere - in the exact same way as in Node 13 and before - but in most cases it will work just fine. And I agree with you: ideally, tl;dr
|
Replaced with |
Thank you for the fix. Had the same issue on Windows and WSL2 and the latest |
Update webapp babel (via manual lockfile deletion & reinstall) due to babel/babel#11216 Update webapp node-sass for Node 14 support Update webapp element-ui due to ElemeFE/element#19389 Update graphql bcrypt to hopefully fix rebuild-on-node-version-change behavior Update graphql knex/pg to fix knex/knex#3836 Update graphql winston to fix winstonjs/winston#1797 Update graphql ts-node-dev to fix wclr/ts-node-dev#143 Pin version of graphql graphql-binding because I remember newer versions not being compatible Remove hacks needed for node 8 (asyncIterator polyfill, incorrect date format in ElapsedTime.spec.ts) Updated FilterPanel snapshot. It seems the reason it was reordered was because Array.prototype.sort started using a stable sorting algorithm in Node 11, and `sortFilterKeys` in store/mutations.js sorts against the same value for most items.
* Upgrade node to v14 Update webapp babel (via manual lockfile deletion & reinstall) due to babel/babel#11216 Update webapp node-sass for Node 14 support Update webapp element-ui due to ElemeFE/element#19389 Update graphql bcrypt to hopefully fix rebuild-on-node-version-change behavior Update graphql knex/pg to fix knex/knex#3836 Update graphql winston to fix winstonjs/winston#1797 Update graphql ts-node-dev to fix wclr/ts-node-dev#143 Pin version of graphql graphql-binding because I remember newer versions not being compatible Remove hacks needed for node 8 (asyncIterator polyfill, incorrect date format in ElapsedTime.spec.ts) Updated FilterPanel snapshot. It seems the reason it was reordered was because Array.prototype.sort started using a stable sorting algorithm in Node 11, and `sortFilterKeys` in store/mutations.js sorts against the same value for most items. * Re-enable supervisorctl autorestart * Debug logging about node versions * Ansible fixes * Fix use of nvm in Ansible/Supervisor * Update CircleCI image for Node 14 * Update graphql lockfile * Update suggested fix for missing DB schema during provision * Re-disable sm-cluster-autostart-daemon autorestart * Make "sm_activate_nvm" variable to simplify nvm use * Fix after merge
Hello,
I just upgraded node to v14 on my fedora 31.
It seems this package is now broken due to this commit : nodejs/node@67e067eb06
Also check updated doc : fs.watch doc
Output error example :
Using recursive: true now throws an Error that is not handled.
https://github.com/whitecolor/ts-node-dev/blob/c0df64c43455d2f8ef144eb9defcd05b6fc52486/lib/index.js#L45
The text was updated successfully, but these errors were encountered: