Check saved conversion status #23
Conversation
Check saved conversion status from DB and execute only if not equal to required status
|
I think the exception handling is ok - BUT I think we want a new string to tell users to check the database fixer - rather than displaying the contents of the db error they will likely not understand! |
|
No wait why are we calling |
|
execute? my mistake, was copied from somwehere. yes, move the "$convertedDB = $db->loadResult();" from below to withint the try, replacing the execute thing. |
|
Awesome :) OK so if you do that. I'll deal with the language string :) |
Is this ok, will the $convertedDB be visible outside thy try block?
|
Can you check the question in the comment of my last commit? |
|
if not visible, i have to initialize it with -1, not with 0, otherwise it will be checked to be ok when equal to uninitilalized value or 0. |
|
It's visible - obviously if you had gone into the catch it wouldn't be - but as we return there it's not a problem |
|
I asked because in c++ it would not be visible outside the try if defined inside it |
|
well as i'm about to be doing a crap load of c++ debugging for my job next week that's useful to know :P |
|
@wilsonge sorry, found syntax error in my select ... closing bracket missing. will make pr for you. |
Dashboard and Installation - BS4 integration
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
* Jsonapi implementation for JDocumentJson. * File name update.
… to the css compile script (#23) * Rename templates/cassiopeia/scss/font--josefin-sans.scss to templates/cassiopeia/scss/fonts/josefin-sans.scss * Rename templates/cassiopeia/scss/font--montserrat.scss to templates/cassiopeia/scss/fonts/montserrat.scss * Fix PHP and SCSS code style * More PHP code style * Finish the sub folder move * Add fonts scss to the compile script
2 participants
Check saved conversion status from DB and execute only if not equal to required status
Please George check if OK.
I am not sure if we need the exception handling for the select statement or if it fits your needs, i.e. return ok or better not, type of message and so on.
I have not tested it yet.