Skip to content

Stop playing the video on the modal close #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Stop playing the video on the modal close #15

wants to merge 1 commit into from

Conversation

@dgrammatiko
Copy link

@dgrammatiko dgrammatiko commented Sep 4, 2015

Caution this isn’t full proof solution as it will start playing the video on the modal exit if video was paused before :(
This needs one more if statement but can figure out how to get the player’s state

Stop playing the video on the modal close
77f4216 
Caution this isn’t full proof solution as it will start playing the video on the modal exit if video was paused before :(
@dgrammatiko dgrammatiko mentioned this pull request Sep 4, 2015
Closed
@wilsonge
Copy link
Owner

wilsonge commented Sep 4, 2015

I'm pretty sure there is a pause function (see: http://mediaelementjs.com/#installation - section 3). I'll have a play around with the code you provided

@wilsonge
Copy link
Owner

wilsonge commented Sep 4, 2015

Combining your code here with that in http://stackoverflow.com/questions/7729305/pause-mediaelement-js-using-jquery I fixed this in 7df7bbe

Thanks for the tips :)

@wilsonge wilsonge closed this Sep 4, 2015
@dgrammatiko dgrammatiko deleted the patch-1 branch September 11, 2015 18:11
wilsonge pushed a commit that referenced this pull request May 7, 2016
@brianteeman
Merge pull request #15 from joomla/staging
dc174f8 
Update from upstream
wilsonge pushed a commit that referenced this pull request Jun 4, 2016
@zero-24 @roland-d
[next batch] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8') (j…
d86ba26 
…oomla#10424)

* Update icon.php

* Update default_core.php

* Update mod_articles_categories.php

* Update default.php

* Update compare.php

* Update default_url.php

* Update mod_tags_popular.php

* Update modules.php

* Update frontediting_modules.php

* Update index.php

* Update component.php

* fixes (#15)

* revert name change
wilsonge pushed a commit that referenced this pull request Aug 28, 2016
@Ruchiranga @rdeutz
Google Summer of Code 2016 JavaScript Testing project (joomla#11420)
6021a45 
* Initial test environment setup with Jasmine, Karma and RequireJS

* Seperated test setup code from test logic

* Configured .travis.yml to run Karma

* Fixed typo in .travis.yml

* changes to .travis.yml

* Added karma requirejs module

* Removed unnecessary code in travis.yml

* Fixed missing code is travis.yml

* Removed 2 unused image files

* Improved code standards

* Modified travis.yml

* Issue 1 Cleaned the mess with changes bunch of to unrelated files

* Issue 1 Added newline at end of file

* Issue 4 Improved JCaption JavaScript tests

* New coeverage reporter plugin test with Travis

* Issue 1 Added karma-coerage reporter and configured it to display coverage on console

* Issue 1 Added and configured karma-verbose-reporter plugin

* Issue 1 Fixing verbose reporter config for travis

* Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures

* Issue 4 Improved code with suggestions made in the code review

* Issue 1 Added version for requirejs text plugin

* Issue 1 converted space indentations to tabs

* Issue 1 Fixed indentation in package.json

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 1 Fixed version issue in require text

* Issue 4 Improved code standards and jquer selector efficiency

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Tersting version issue with text plugin on travis

* Issue 1 Removed spec folder

* Corejs tests (#15)

Tests for core.js

* Tests for permissions.js (#13)

* Test suite for permissions.js
* Added karma-jasmine-ajax plugin

* Added a container div for fixtures representing library name (#11)

* Added a container div for fixtures representing the library name

* CS - Removed an extra new line

* Permissions.js tests

Test for permissions

* Repeatable.js test suite

* Improvements to JCaption tests

* README.md update

* Modified readme file
* Made running tests easier by adding configuration for tests to run on npm test

* Core js Improvements

* Issue 9 Added jasmine spies and improved code
* Issue 9 Fixed an indentation issue

* Demo video on Youtube 

* Inserted the video demonstration link to the readme

* Issue 5 Added spies and made code improvements (#31)

* Issue 12 Improved code (#34)

* Repeatable.js Improvements (#35)

* Run Travis JavaScript tests on separated Matrix Build (#39)

* Only run Travis tests on PHP 7

* Fix base path issue

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Added own matrix tests for JavaScript

* Reverted README.md

* Synced README.md to the new version

* Synced README.md with new version

* Fixed indentations

* Synced README.md with 3.6 version

* Fixed indentations

* Fixed indentations
* Added newline at the end of travis-tests.sh

* Added missing sudo:false in .travis.yml
wilsonge pushed a commit that referenced this pull request Jun 3, 2017
@brianteeman @wilsonge
[codestyle] admin components xml files (joomla#15920)
6c66636 
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
wilsonge pushed a commit that referenced this pull request Jul 10, 2018
@zero-24 @wilsonge
Fixing PHPCS (#15)
3a999ee 
* Update ApiApplication.php

* Update ApiApplication.php

* Update ApiApplication.php
wilsonge pushed a commit that referenced this pull request Sep 10, 2018
@mbabker
[Feature] Tracking Information Requests (#15)
8b38009
wilsonge pushed a commit that referenced this pull request Dec 31, 2021
@laoneo @Fedik @HLeithner
[4.1] Add some events when fetching media data (joomla#35396)
c64bee8 
* Add some events when fetching media data

* Use dispatcher to trigger event

* Use an event instance

* Class per event (#15)

* Argument validations and getter (#16)

* Class per event

* Argument validations

* global

* Use result from events

* Copy year

* Use internal variable

* void

* adapt model

* Validate events (#17)

* Revert commit ec8b4c8 ccd02cb and 9a2a119

* Validate and immutable events

* Update administrator/components/com_media/src/Event/FetchMediaFileEvent.php

Co-authored-by: Harald Leithner <[email protected]>

* Update administrator/components/com_media/src/Event/FetchMediaFilesEvent.php

Co-authored-by: Harald Leithner <[email protected]>

* Rename the events

* Cleanup events

Co-authored-by: Fedir Zinchuk <[email protected]>
Co-authored-by: Harald Leithner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgrammatiko @wilsonge