Skip to content

Add pg log source to log entries. #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
will merged 1 commit into from
Apr 30, 2025
Merged

Add pg log source to log entries. #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/pq/pgpass_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ describe PQ::PgPass, ".parsing" do
create_valid_pgpass_file do |filename|
File.chmod(filename, 0o0700)
ENV["PGPASSFILE"] = filename
Log.capture {
Log.capture("pg") {
ci = PQ::ConnInfo.from_conninfo_string("postgres://")
}.itself
.check(:warn, "Cannot use pgpass file - permissions are inappropriate must be 0600 or less")
Expand All @@ -70,7 +70,7 @@ describe PQ::PgPass, ".parsing" do
env_var_bubble do
create_invalid_pgpass_file do |filename|
ENV["PGPASSFILE"] = filename
Log.capture {
Log.capture("pg") {
ci = PQ::ConnInfo.from_conninfo_string("postgres://")
}.itself
.check(:warn, "PGPass file does not appear to be properly formatted - errors may occur")
Expand Down
2 changes: 2 additions & 0 deletions src/pq/pgpass.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
module PQ
Log = ::Log.for("pg")

class PgPass
def self.locate(host : String, port : Int, db : String, user : String) : String?
filename = ENV.fetch("PGPASSFILE", Path["~/.pgpass"].expand(home: true).to_s)
Expand Down