fix: Backported #36820 to fix discussion threads - #655
Merged
Syed-Ali-Abbas-568 merged 1 commit intoJun 29, 2026
Merged
Conversation
ahmed-arb
approved these changes
Jun 29, 2026
Syed-Ali-Abbas-568
merged commit Jun 29, 2026
a80153c
into
wikimedia:develop-teak
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the forum v2 search/listing fix from upstream PR openedx/edx-platform#36820 to our
develop-teakfork. The discussion thread-listing endpoint was returning empty results when filtered by topic (topic_id=course), even though threads existed under that topic — causing topics to appear briefly then vanish in the Discussions MFE. The fix corrects how request params are built and sanitized (clean_forum_params) before being sent to the forum v2 backend.Only the backend
comment_clientsource files are backported (thread.py,user.py,utils.py); the upstream test files were omitted as they target v2 modules not present in this fork.