Skip to content

fix: Backported #36820 to fix discussion threads - #655

Merged
Syed-Ali-Abbas-568 merged 1 commit into
wikimedia:develop-teakfrom
Syed-Ali-Abbas-568:fix/forum-v2-search-backport
Jun 29, 2026
Merged

fix: Backported #36820 to fix discussion threads#655
Syed-Ali-Abbas-568 merged 1 commit into
wikimedia:develop-teakfrom
Syed-Ali-Abbas-568:fix/forum-v2-search-backport

Conversation

@Syed-Ali-Abbas-568

Copy link
Copy Markdown
Collaborator

Description

Backports the forum v2 search/listing fix from upstream PR openedx/edx-platform#36820 to our develop-teak fork. The discussion thread-listing endpoint was returning empty results when filtered by topic (topic_id=course), even though threads existed under that topic — causing topics to appear briefly then vanish in the Discussions MFE. The fix corrects how request params are built and sanitized (clean_forum_params) before being sent to the forum v2 backend.

Only the backend comment_client source files are backported (thread.py, user.py, utils.py); the upstream test files were omitted as they target v2 modules not present in this fork.

  • Impacted roles: Learner, Course Author (anyone using course discussions)
  • No UI changes — backend-only; the MFE renders correctly once the API returns proper data.

@Syed-Ali-Abbas-568
Syed-Ali-Abbas-568 merged commit a80153c into wikimedia:develop-teak Jun 29, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants