feat!: remove cs_comments_service support for forum's search APIs - #36820
Conversation
03619b7 to
5493ca6
Compare
|
@ormsbee Can you please review this? |
|
@ormsbee, |
|
I will have a review done today. Thank you. |
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
I'm still looking through the test code, but here's my first pass.
ormsbee
left a comment
ormsbee
left a comment
There was a problem hiding this comment.
A few minor requests and questions.
| actual_has_group = "group_id" in thread_func_params | ||
| expected_has_group = ( | ||
| course_is_cohorted and role_name in ( | ||
| FORUM_ROLE_STUDENT, FORUM_ROLE_COMMUNITY_TA, FORUM_ROLE_GROUP_MODERATOR | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Could you please explain in a bit more detail about how this works?
There was a problem hiding this comment.
This test verifies thread visibility based on cohort membership and user roles. It tests whether the group_id is passed to the user_thread function or not.
- If a user is part of a cohort, a group_id (representing the cohort) is passed in the thread query.
- Only threads associated with that group_id are returned.
- If a user is not part of the cohort but has elevated permissions (e.g., Community TA or Group Moderator), the same group_id is passed.
- In both cases, the API should return only the threads linked to the specified group_id.
There was a problem hiding this comment.
@ormsbee Are we in the state of merging this?
544b0c8 to
c5dec63
Compare
c5dec63 to
215a235
Compare
This will force the use of the new v2 forum's APIs for searching.
7e8da63 to
54cd8e5
Compare
|
@ormsbee All issues have been fixed. Can we merge this PR? |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
…ackport fix: Backported openedx#36820 to fix discussion threads
3 participants
Description
This pull request removes legacy code related to the "search" api functionality within the discussion forum v1 app. The rationale behind this change is to clean up deprecated or unused code paths, thereby simplifying the codebase and reducing potential maintenance overhead.
Implications for users:
• There should be no impact on end-users, as the removed code pertains to deprecated functionality that is no longer in active use.
• Developers working on the discussion forum module will benefit from a cleaner codebase, making future enhancements and maintenance more straightforward.