-
-
Notifications
You must be signed in to change notification settings - Fork 150
Fixes/browser seperators rendering #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wieslawsoltes
merged 5 commits into
wieslawsoltes:master
from
danwalmsley:fixes/browser-seperators-rendering
Mar 10, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
78257bb
fix browser tab seperator rendering.
danwalmsley 6e54862
delayeduniformtabpanel pixel rounding.
danwalmsley c9ad9a0
Revert "fix browser tab seperator rendering."
danwalmsley feceb8a
fix tests
danwalmsley 6666527
Fix tab panel pixel snapping
danwalmsley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
tabWidthis capped (for example, wide viewport with a few tabs), this branch makes the final visible tab end atfinalSize.Width, so it absorbs all trailing space instead of keeping the uniform width computed byResolveTabWidth. In a 1000px layout with 3 tabs andMaxTabWidth=220, the last tab becomes ~552px wide while earlier tabs stay 220px, which breaks the panel’s uniform-tab contract and contradicts the existing headless expectation that all tabs remain equal width (tests/Dock.Avalonia.HeadlessTests/DelayedUniformTabPanelTests.cs,UsesUniformMaxWidthWhenSpaceIsAvailable).Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 6666527