Fixes/browser seperators rendering#1070
Conversation
|
@codex review |
|
@codex fix ci failures |
|
Codex couldn't complete this request. Try again later. |
|
@codex fix ci failures |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c9ad9a0db4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var endX = arrangedIndex == visibleCount - 1 | ||
| ? finalSize.Width | ||
| : RoundToDevicePixels(x + tabWidth); |
There was a problem hiding this comment.
When tabWidth is capped (for example, wide viewport with a few tabs), this branch makes the final visible tab end at finalSize.Width, so it absorbs all trailing space instead of keeping the uniform width computed by ResolveTabWidth. In a 1000px layout with 3 tabs and MaxTabWidth=220, the last tab becomes ~552px wide while earlier tabs stay 220px, which breaks the panel’s uniform-tab contract and contradicts the existing headless expectation that all tabs remain equal width (tests/Dock.Avalonia.HeadlessTests/DelayedUniformTabPanelTests.cs, UsesUniformMaxWidthWhenSpaceIsAvailable).
Useful? React with 👍 / 👎.
|
Codex couldn't complete this request. Try again later. |
2 participants
Due to not snapping to pixels the browser tab separators would shimmer and toggle visibility as the layout changes.