Stop claiming callback interfaces are interfaces #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Apr 4, 2019
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
I admit not being able to review every line, but overall this change makes sense, and I did my best to read through and try to spot any problem areas.
Callback interfaces and interfaces have very little in common, so this makes them separate concepts. It doesn't change the name or syntax to avoid unhelpful churn.
Ms2ger
force-pushed
the
callback-interface-split
branch
from
fd3f21e to
4389470
Compare
Ms2ger
added a commit
that referenced
this pull request
Jul 1, 2019
I accidentally missed a letter in #705.
bzbarsky
pushed a commit
that referenced
this pull request
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback interfaces and interfaces have very little in common, so this makes
them separate concepts. It doesn't change the name or syntax to avoid
unhelpful churn.
Preview | Diff