idlharness.js shouldn't apply checks for interfaces to callback inter… #36135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@foolip are you still the right reviewer for idlharness changes? |
foolip
approved these changes
Oct 31, 2022
Member
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Makes sense, thanks for fixing! This will remove some tests in dom/:
https://wpt.fyi/results/dom/idlharness.window.html%3Fexclude%3DNode?diff&filter=ADC&run_id=5181333035286528&run_id=5089041066754048
Member
|
wpt-chrome-dev-stability failures are in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback interfaces are different from interfaces (this was changed in whatwg/webidl#705), and a lot of the tests for interfaces do not make sense for callback interfaces. Essentially any callback interface can be implemented by any ECMAScript object (see https://webidl.spec.whatwg.org/#idl-callback-interfaces: It can be implemented by any object).