Allow document.open() to be called on non-active documents #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no longer anything fundamental that prevents document.open() from being useful on non-active documents. This also aligns with Chrome, Edge, and Safari. In fact, several projects like AMP already utilize this property as a streaming HTML parser to desirable effects. Fixes whatwg#2827. Tests: web-platform-tests/wpt#12636 Tests: …
TimothyGu
added
needs tests
19 tasks
domenic
approved these changes
Aug 30, 2018
domenic
requested changes
Aug 30, 2018
TimothyGu
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 30, 2018
TimothyGu
removed
the
needs tests
domenic
approved these changes
Aug 30, 2018
TimothyGu
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 4, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 10, 2018
…ocuments, a=testonly Automatic update from web-platform-testsdocument.open(): Test non-fully active documents (#12770) For whatwg/html#3977. -- wpt-commits: 61bc4ecc726596e5ce8634752e09a5e8a20e060f wpt-pr: 12770
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Sep 10, 2018
…ocuments, a=testonly Automatic update from web-platform-testsdocument.open(): Test non-fully active documents (#12770) For whatwg/html#3977. -- wpt-commits: 61bc4ecc726596e5ce8634752e09a5e8a20e060f wpt-pr: 12770
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…ocuments, a=testonly Automatic update from web-platform-testsdocument.open(): Test non-fully active documents (#12770) For whatwg/html#3977. -- wpt-commits: 61bc4ecc726596e5ce8634752e09a5e8a20e060f wpt-pr: 12770 UltraBlame original commit: d273278eecdf8fb4262cd2cd9b6f312e123c8b24
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…ocuments, a=testonly Automatic update from web-platform-testsdocument.open(): Test non-fully active documents (#12770) For whatwg/html#3977. -- wpt-commits: 61bc4ecc726596e5ce8634752e09a5e8a20e060f wpt-pr: 12770 UltraBlame original commit: d273278eecdf8fb4262cd2cd9b6f312e123c8b24
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…ocuments, a=testonly Automatic update from web-platform-testsdocument.open(): Test non-fully active documents (#12770) For whatwg/html#3977. -- wpt-commits: 61bc4ecc726596e5ce8634752e09a5e8a20e060f wpt-pr: 12770 UltraBlame original commit: d273278eecdf8fb4262cd2cd9b6f312e123c8b24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no longer anything fundamental that prevents
document.open()from being useful on non-active documents. This also aligns with Chrome, Edge, and Safari. In fact, several projects like AMP already utilize this property as a streaming HTML parser to desirable effects.Additionally, use a more appropriate guard for erasing event listeners and handlers on the
Windowobject, as revealed by the tests.Fixes #2827.
Tests: web-platform-tests/wpt#12636
Tests: web-platform-tests/wpt#12770
/dynamic-markup-insertion.html ( diff )