document.open(): Test non-fully active documents #12770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
19 tasks
|
Oops the branch should be "timothygu/document-open-activity" as it's a new branch and not one of the existing tests… sorry @annevk! |
domenic
reviewed
Aug 31, 2018
html/webappapis/dynamic-markup-insertion/opening-the-input-stream/active.window.js
Outdated
Show resolved
Hide resolved
html/webappapis/dynamic-markup-insertion/opening-the-input-stream/active.window.js
Outdated
Show resolved
Hide resolved
html/webappapis/dynamic-markup-insertion/opening-the-input-stream/active.window.js
Outdated
Show resolved
Hide resolved
html/webappapis/dynamic-markup-insertion/opening-the-input-stream/active.window.js
Outdated
Show resolved
Hide resolved
html/webappapis/dynamic-markup-insertion/opening-the-input-stream/active.window.js
Outdated
Show resolved
Hide resolved
html/webappapis/dynamic-markup-insertion/opening-the-input-stream/active.window.js
Outdated
Show resolved
Hide resolved
|
Also need (as a separate PR if you like) tests that event listeners don't get erased in these cases. And ideally tests that aborting doesn't happen, although I know aborting is still WIP. |
This doesn't seem to work on browsers that should have already implemented the check. In Chrome (and presumably Safari), event listeners get erased in any case the Document is created alongside a Window object – including when the Document is inactive or does not have its browsing context. We don't seem to have a name for that yet. |
|
@domenic Added some tests for event listeners as well. PTAL. |
domenic
approved these changes
Sep 4, 2018
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Sep 4, 2018
There is no longer anything fundamental that prevents document.open() from being useful on non-active documents. This also aligns with Chrome, Edge, and Safari. In fact, some developers already utilize this property as a streaming HTML parser to desirable effect (see #2827). Additionally, use a more appropriate guard for erasing event listeners and handlers on the Window object, as revealed by the tests. Fixes #2827. Tests: web-platform-tests/wpt#12636 Tests: web-platform-tests/wpt#12770
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
There is no longer anything fundamental that prevents document.open() from being useful on non-active documents. This also aligns with Chrome, Edge, and Safari. In fact, some developers already utilize this property as a streaming HTML parser to desirable effect (see whatwg#2827). Additionally, use a more appropriate guard for erasing event listeners and handlers on the Window object, as revealed by the tests. Fixes whatwg#2827. Tests: web-platform-tests/wpt#12636 Tests: web-platform-tests/wpt#12770
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
There is no longer anything fundamental that prevents document.open() from being useful on non-active documents. This also aligns with Chrome, Edge, and Safari. In fact, some developers already utilize this property as a streaming HTML parser to desirable effect (see whatwg#2827). Additionally, use a more appropriate guard for erasing event listeners and handlers on the Window object, as revealed by the tests. Fixes whatwg#2827. Tests: web-platform-tests/wpt#12636 Tests: web-platform-tests/wpt#12770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a missing file in the related
url.jstest.For whatwg/html#3977.
All six tests pass in Chrome and Safari.
The "active but not fully active" and "non-active with associated Window; navigated away" cases fail in Edge with a "Permission denied" error, but all others pass.
All but the first one fail in Firefox, which implements the active document bailout