Add references to WebGL 2.0 ("webgl2") context. #3971

kenrussell · 2018-08-28T22:01:56Z

/acknowledgements.html ( diff )
/canvas.html ( diff )
/infrastructure.html ( diff )
/references.html ( diff )

kenrussell · 2018-08-28T22:03:44Z

Sorry for taking so long to finally do this.

A slight shortcut was taken in the updating of the tables for getContext for Canvas elements and OffscreenCanvas objects. Rather than add both a new row and column, the webgl and webgl2 contexts were combined. This seemed appropriate because the WebGL reference actually points to the shared location of the 1.0 and 2.0 specs.

Also added @jdashg as WebGL spec editor in the reference.

kenrussell · 2018-08-28T22:04:19Z

Note also: built the spec locally and verified by hand that these edits look good.

annevk

This looks great, thanks for writing it up. Here's a bunch of nits (some up for debate).

Also, is this already tested adequately?

annevk · 2018-08-29T06:57:17Z

source

@@ -3867,10 +3867,11 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute

   <dd>

-    <p>The following interface is defined in the WebGL specification: <ref spec=WEBGL></p>
+    <p>The following interfaces are defined in the WebGL specification: <ref spec=WEBGL></p>


You switched to plural at some point below and since the reference we have is for both, let's make this "WebGL specifications".

annevk · 2018-08-29T07:01:10Z

source

@@ -59471,6 +59473,12 @@ callback <dfn>BlobCallback</dfn> = void (<span>Blob</span>? blob);</code></pre>
     <td>


I think it would be better to add rowspan="2" here than duplicate its paragraph below.

Actually – since these two were combined in a single row, the rowspan="2" annotation wasn't needed.

annevk · 2018-08-29T07:01:19Z

source

@@ -59471,6 +59473,12 @@ callback <dfn>BlobCallback</dfn> = void (<span>Blob</span>? blob);</code></pre>
     <td>
      <p>Follow the behavior defined in the WebGL specification. <ref spec=WEBGL></p>


specifications*

annevk · 2018-08-29T07:02:13Z

source

-    spec=WEBGL></p>
+    data-x="canvas-context-bitmaprenderer">bitmaprenderer</code>" contexts below. There are also
+    specifications that define "<code data-x="canvas-context-webgl">webgl</code>" and "<code
+    data-x="canvas-context-webgl2">webgl2</code>" contexts. <ref spec=WEBGL></p>


Let's make this "The WebGL specifications define the ..."

annevk · 2018-08-29T07:03:01Z

source

@@ -59545,7 +59554,8 @@ callback <dfn>BlobCallback</dfn> = void (<span>Blob</span>? blob);</code></pre>
       <th><span data-x="concept-canvas-none">none</span>
       <th><span data-x="concept-canvas-2d">2d</span>
       <th><span data-x="concept-canvas-bitmaprenderer">bitmaprenderer</span>
-       <th><span data-x="concept-canvas-webgl">webgl</span>
+       <th><span data-x="concept-canvas-webgl">webgl</span> or <span
+         data-x="concept-canvas-webgl2">webgl2</span>


The d of data-x needs to be aligned with the < of <th> I think.

annevk · 2018-08-29T07:05:54Z

source

@@ -65189,7 +65206,8 @@ interface <dfn>OffscreenCanvas</dfn> : <span>EventTarget</span> {
       <td>
       <th><span data-x="offscreencanvas-context-none">none</span>
       <th><span data-x="offscreencanvas-context-2d">2d</span>
-       <th><span data-x="offscreencanvas-context-webgl">webgl</span>
+       <th><span data-x="offscreencanvas-context-webgl">webgl</span> or <span
+         data-x="offscreencanvas-context-webgl2">webgl2</span>


annevk · 2018-08-29T07:06:00Z

source

@@ -65211,14 +65229,17 @@ interface <dfn>OffscreenCanvas</dfn> : <span>EventTarget</span> {
       <td>
        Throw an <span>"<code>InvalidStateError</code>"</span> <code>DOMException</code>.
      <tr>
-       <th>"<dfn><code data-x="offscreen-context-type-webgl">webgl</code></dfn>"
+       <th>"<dfn><code data-x="offscreen-context-type-webgl">webgl</code></dfn>" or "<dfn><code
+         data-x="offscreen-context-type-webgl2">webgl2</code></dfn>"


annevk · 2018-08-29T07:06:14Z

source

@@ -65211,14 +65229,17 @@ interface <dfn>OffscreenCanvas</dfn> : <span>EventTarget</span> {
       <td>
        Throw an <span>"<code>InvalidStateError</code>"</span> <code>DOMException</code>.
      <tr>
-       <th>"<dfn><code data-x="offscreen-context-type-webgl">webgl</code></dfn>"
+       <th>"<dfn><code data-x="offscreen-context-type-webgl">webgl</code></dfn>" or "<dfn><code
+         data-x="offscreen-context-type-webgl2">webgl2</code></dfn>"
       <td>
        Follow the instructions given in the WebGL specification's <i>Context Creation</i> section


specifications'*
sections*?

annevk · 2018-08-29T07:11:08Z

source

-        data-x="offscreencanvas-context-webgl">webgl</span>, and return the
-        <code>WebGLRenderingContext</code> object. <ref spec=WEBGL>
+        to obtain either a <code>WebGLRenderingContext</code>, <code>WebGL2RenderingContext</code>
+        or null; if the returned value is null, then return null; otherwise, set this


Oxford comma

annevk · 2018-08-29T07:11:25Z

source

-  contexts is defined in the WebGL specification. <ref spec=WEBGL></p>
+  <p>The resizing behavior for "<code data-x="offscreen-context-type-webgl">webgl</code>" and "<code
+  data-x="offscreen-context-type-webgl2">webgl2</code>" contexts is defined in the WebGL
+  specification. <ref spec=WEBGL></p>


specifications*

annevk · 2018-08-29T07:15:06Z

Also, your name isn't in the Acknowledgments section, please add it?

(And you'll need to make your membership of the google GitHub organization public.)

kenrussell · 2018-08-29T18:59:28Z

Addressed all review feedback. Added myself to acknowledgments section. Made my Google organization membership public on Github. Please re-review.

domenic · 2018-08-29T20:07:06Z

source

-      <p>Follow the behavior defined in the WebGL specification. <ref spec=WEBGL></p>
-
-    <tr>
+    <tr rowspan="2">


rowspan needs to be on the td, not the tr

Removed. Since I merged these rows together it wasn't needed anyway.

annevk

LGTM with my own nits applied (please double check). The only question remaining here is tests and I suppose implementer bugs, but I think this has been implemented to some extent already?

This test covers the following HTML spec pull request: whatwg/html#3971

kenrussell · 2018-08-30T06:53:05Z

Fixes for nits look fine.

Adding a specific test for webgl2 vs. webgl context types in KhronosGroup/WebGL#2701 . Aside from that, https://github.com/KhronosGroup/WebGL already contains a thorough conformance suite for both WebGL 1.0 and 2.0.

This test covers the following HTML spec pull request: whatwg/html#3971

Add references to WebGL 2.0 ("webgl2") context.

85ae671

Fixes whatwg#3404.

domenic added the topic: canvas label Aug 28, 2018

annevk reviewed Aug 29, 2018

View reviewed changes

kenrussell added 2 commits August 29, 2018 11:57

Address review feedback from annevk

cb554c4

Add myself to acknowledgments

49aead1

domenic reviewed Aug 29, 2018

View reviewed changes

kenrussell and others added 2 commits August 29, 2018 15:08

Address review feedback from domenic

6a4aaba

nits

4276401

annevk approved these changes Aug 30, 2018

View reviewed changes

kenrussell added a commit to kenrussell/WebGL that referenced this pull request Aug 30, 2018

Test webgl2 vs. webgl canvas context modes.

00ed900

This test covers the following HTML spec pull request: whatwg/html#3971

kenrussell mentioned this pull request Aug 30, 2018

Test webgl2 vs. webgl canvas context modes. KhronosGroup/WebGL#2701

Merged

kenrussell mentioned this pull request Aug 30, 2018

Please document how to use whatpr.org #3974

Closed

annevk merged commit 3a20936 into whatwg:master Aug 30, 2018

kenrussell deleted the add-webgl2-context branch August 30, 2018 21:45

kenrussell added a commit to KhronosGroup/WebGL that referenced this pull request Aug 30, 2018

Test webgl2 vs. webgl canvas context modes. (#2701)

fba3728

This test covers the following HTML spec pull request: whatwg/html#3971

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add references to WebGL 2.0 ("webgl2") context. #3971

Add references to WebGL 2.0 ("webgl2") context. #3971

kenrussell commented Aug 28, 2018 •

edited by pr-preview bot

Loading

kenrussell commented Aug 28, 2018

kenrussell commented Aug 28, 2018

annevk left a comment

annevk Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk Aug 29, 2018

kenrussell Aug 29, 2018

annevk commented Aug 29, 2018

kenrussell commented Aug 29, 2018

domenic Aug 29, 2018

kenrussell Aug 29, 2018

annevk left a comment

kenrussell commented Aug 30, 2018

		@@ -59471,6 +59473,12 @@ callback <dfn>BlobCallback</dfn> = void (<span>Blob</span>? blob);</code></pre>
		<td>

		@@ -59471,6 +59473,12 @@ callback <dfn>BlobCallback</dfn> = void (<span>Blob</span>? blob);</code></pre>
		<td>
		<p>Follow the behavior defined in the WebGL specification. <ref spec=WEBGL></p>

Add references to WebGL 2.0 ("webgl2") context. #3971

Add references to WebGL 2.0 ("webgl2") context. #3971

Conversation

kenrussell commented Aug 28, 2018 • edited by pr-preview bot Loading

kenrussell commented Aug 28, 2018

kenrussell commented Aug 28, 2018

annevk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk commented Aug 29, 2018

kenrussell commented Aug 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annevk left a comment

Choose a reason for hiding this comment

kenrussell commented Aug 30, 2018

kenrussell commented Aug 28, 2018 •

edited by pr-preview bot

Loading