Change name from target client id to replaces client id #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had decided to change the name of FetchEvent.targetClientId to .replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id. Related issue: w3c/ServiceWorker#1245. SW PR: w3c/ServiceWorker#1333. Fetch PR: whatwg/fetch#774.
This was referenced Jul 1, 2018
domenic
approved these changes
Jul 2, 2018
domenic
requested changes
Jul 2, 2018
source
Outdated
| @@ -2832,7 +2832,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |||
| <li><dfn data-x="concept-request-body" data-x-href="https://fetch.spec.whatwg.org/#concept-request-body">body</dfn></li> | |||
| <li><dfn data-x="concept-request-client" data-x-href="https://fetch.spec.whatwg.org/#concept-request-client">client</dfn></li> | |||
| <li><dfn data-x="concept-request-reserved-client" data-x-href="https://fetch.spec.whatwg.org/#concept-request-reserved-client">reserved client</dfn></li> | |||
| <li><dfn data-x="concept-request-target-client-id" data-x-href="https://fetch.spec.whatwg.org/#concept-request-target-client-id">target client id</dfn></li> | |||
| <li><dfn data-x="concept-request-target-client-id" data-x-href="https://fetch.spec.whatwg.org/#concept-request-replaces-client-id">replaces client id</dfn></li> | |||
There was a problem hiding this comment.
Oh wait, need to update this data-x too, otherwise the build will fail.
There was a problem hiding this comment.
Thanks for catching this. I updated it.
domenic
added
the
do not merge yet
domenic
approved these changes
Jul 2, 2018
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Aug 24, 2018
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the name of request's target client id to replaces client id. See also: * w3c/ServiceWorker#1245 * w3c/ServiceWorker#1333 * whatwg/html#3788
annevk
removed
the
do not merge yet
jungkees
added a commit
to w3c/ServiceWorker
that referenced
this pull request
Aug 26, 2018
We had decided (and I forgot) to change the name of FetchEvent.targetClientId to .replacesClientId to clarify the meaning that this client is a to-be-replaced client: #1091 (comment). Fetch PR: whatwg/fetch#774. HTML PR: whatwg/html#3788. Related issue: #1245.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had decided to change the name of FetchEvent.targetClientId to
.replacesClientId to clarify the meaning that this client is a to be replaced
client: w3c/ServiceWorker#1091 (comment).
Accordingly, this changes the reference to the request's target client id to
request's replaces client id.
Related issue: w3c/ServiceWorker#1245.
SW PR: w3c/ServiceWorker#1333.
Fetch PR: whatwg/fetch#774.
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )