Change name from target client id to replaces client id #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had decided to change the name of FetchEvent.targetClientId to .replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the name of the request's target client id item to replaces client id. Related issue: w3c/ServiceWorker#1245. SW PR: w3c/ServiceWorker#1333.
jungkees
added a commit
to jungkees/html
that referenced
this pull request
Jul 1, 2018
We had decided to change the name of FetchEvent.targetClientId to .replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id. Related issue: w3c/ServiceWorker#1245. SW PR: w3c/ServiceWorker#1333. Fetch PR: whatwg/fetch#774.
This was referenced Jul 1, 2018
|
I find the name a little odd. w3c/ServiceWorker#1091 (comment) by @jakearchibald doesn't give me much context. This is the ID of the client that will end up being replaced? Reading it that way makes some sense I suppose. |
annevk
reviewed
Jul 31, 2018
| @@ -734,7 +734,7 @@ requests, but not service worker requests. It references an | |||
| <a>environment settings object</a> for a worker request. | |||
|
|
|||
| <p>A <a for=/>request</a> has an associated | |||
| <dfn id=concept-request-target-client-id export for=request>target client id</dfn> | |||
| <dfn id=concept-request-replaces-client-id export for=request>replaces client id</dfn> | |||
| (a string). Unless stated otherwise it is the empty string. | |||
|
|
|||
| <p class="note no-backref">This is only used by <a>navigation requests</a>. It is the | |||
There was a problem hiding this comment.
Yes, no semantical change, just naming change.
Yep! |
|
@jungkees are you still pursuing this? Any feedback on my line comment above? |
|
@annevk, yes, I'm pursuing this change and left a comment. |
annevk
approved these changes
Aug 24, 2018
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Aug 24, 2018
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id. See also: * w3c/ServiceWorker#1245 * w3c/ServiceWorker#1333 * whatwg/fetch#774
jungkees
added a commit
to w3c/ServiceWorker
that referenced
this pull request
Aug 26, 2018
We had decided (and I forgot) to change the name of FetchEvent.targetClientId to .replacesClientId to clarify the meaning that this client is a to-be-replaced client: #1091 (comment). Fetch PR: whatwg/fetch#774. HTML PR: whatwg/html#3788. Related issue: #1245.
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id. See also: * w3c/ServiceWorker#1245 * w3c/ServiceWorker#1333 * whatwg/fetch#774
mustaqahmed
pushed a commit
to mustaqahmed/html
that referenced
this pull request
Feb 15, 2019
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id. See also: * w3c/ServiceWorker#1245 * w3c/ServiceWorker#1333 * whatwg/fetch#774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had decided to change the name of FetchEvent.targetClientId to
.replacesClientId to clarify the meaning that this client is a to be replaced
client: w3c/ServiceWorker#1091 (comment).
Accordingly, this changes the name of the request's target client id item to
replaces client id.
Related issue: w3c/ServiceWorker#1245.
SW PR: w3c/ServiceWorker#1333.
HTML PR: whatwg/html#3788.
Preview | Diff