Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NavigateEventInit.sourceElement #10971

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Add NavigateEventInit.sourceElement #10971

merged 1 commit into from
Jan 31, 2025

Conversation

AtkinsSJ
Copy link
Contributor

@AtkinsSJ AtkinsSJ commented Jan 30, 2025 •
edited by pr-preview bot
Loading

Fixes #10970.

sourceElement was added to NavigateEvent in #10898 but it was missed in NavigateEventInit.

  • At least two implementers are interested (and none opposed):
    • …
    • …
  • Tests are written and can be reviewed and commented upon at:
    • …
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • Corresponding HTML AAM & ARIA in HTML issues & PRs:
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

/nav-history-apis.html ( diff )

AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Jan 30, 2025
@AtkinsSJ
LibWeb: Add NavigateEvent.sourceElement
db21c69 
Corresponds to whatwg/html#10898

This is with whatwg/html#10971 also applied -
the original PR missed `sourceElement` from the `NavigateEventInit`
dictionary.

I've also updated the imported WPT test as it's been recently changed to
account for 10898 being merged.
@AtkinsSJ AtkinsSJ mentioned this pull request Jan 30, 2025
Merged
domenic
domenic approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and great catch!

@domenic domenic merged commit 1e88525 into whatwg:main Jan 31, 2025
2 checks passed
@AtkinsSJ AtkinsSJ deleted the add-navigateeventinit-sourceelement branch January 31, 2025 08:47
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Jan 31, 2025
@AtkinsSJ
LibWeb: Add NavigateEvent.sourceElement
1323dea 
Corresponds to:
- whatwg/html#10898
- whatwg/html#10971

I've also updated the imported WPT test as it's been recently changed to
account for 10898 being merged.
AtkinsSJ added a commit to AtkinsSJ/ladybird that referenced this pull request Feb 3, 2025
@AtkinsSJ
LibWeb: Add NavigateEvent.sourceElement
f5e4f20 
Corresponds to:
- whatwg/html#10898
- whatwg/html#10971

I've also updated the imported WPT test as it's been recently changed to
account for 10898 being merged.
awesomekling pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Feb 4, 2025
@AtkinsSJ @awesomekling
LibWeb: Add NavigateEvent.sourceElement
26b7946 
Corresponds to:
- whatwg/html#10898
- whatwg/html#10971

I've also updated the imported WPT test as it's been recently changed to
account for 10898 being merged.
@foolip
Copy link
Member

foolip commented Feb 13, 2025

Tests were written in https://chromium-review.googlesource.com/c/chromium/src/+/4385906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: navigation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NavigateEventInit is missing a sourceElement field
3 participants
@AtkinsSJ @foolip @domenic