LibWeb: Add NavigateEvent.sourceElement #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
force-pushed
the
navigate-event-source-element
branch
from
db21c69 to
1323dea
Compare
|
Changes: Rebased (to hopefully avoid the previous flaky tests) and changed the commit message because the spec fix I mentioned is now merged. |
Corresponds to: - whatwg/html#10898 - whatwg/html#10971 I've also updated the imported WPT test as it's been recently changed to account for 10898 being merged.
AtkinsSJ
force-pushed
the
navigate-event-source-element
branch
from
1323dea to
f5e4f20
Compare
|
Changes: Visit the source-element pointer. (Thanks CI!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to whatwg/html#10898
This is with whatwg/html#10971 also applied - the original PR missed
sourceElementfrom theNavigateEventInitdictionary.I've also updated the imported WPT test as it's been recently changed to account for 10898 being merged.