Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input[type=datetime] #336

Closed
tkent-google opened this issue Nov 13, 2015 · 18 comments
Closed

Remove input[type=datetime] #336

tkent-google opened this issue Nov 13, 2015 · 18 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project removal/deprecation Removing or deprecating a feature

Comments

@tkent-google
Copy link
Contributor

https://html.spec.whatwg.org/multipage/forms.html#date-and-time-state-(type=datetime)

Because there is no implementation now though Presto Opera had it.
We don't have a plan to implement it in Blink.

Presto: All input types were supported.
Blink: datetime is not supported.
Edge 13.10586: datetime is not supported.
Mobile Safari: datetime is not supported.
Mobile Firefox: month, week, datetime, and datetime-local are not supported.
Desktop Safari: date, datetime, datetime-local, month, time, and week are not supported.
Desktop Firefox: date, datetime, datetime-local, month, time, and week are not supported.
@zcorpan zcorpan added removal/deprecation Removing or deprecating a feature good first issue Ideal for someone new to a WHATWG standard or software project labels Nov 13, 2015
@annevk
Copy link
Member

annevk commented Nov 13, 2015

I guess it's too late to rename datetime-local to datetime. Bit of a shame. Would making them an alias work?

@foolip
Copy link
Member

foolip commented Nov 14, 2015

Relevant use counters:

Both are counted only when the computed style is is not visibility:hidden. (Not sure why, there are many other ways to not be visible.)

@annevk
Copy link
Member

annevk commented Nov 15, 2015

From that it seems that neither is really used. @hober, do you have views on this? @travisleithead?

@tkent-google
Copy link
Contributor Author

We received multiple bug reports when we introduced a regression of input[type=datetime-local] in Blink. So, I think it has real users, and we won't remove it.

@annevk
Copy link
Member

annevk commented Nov 16, 2015

Alright, I guess removing datetime first would be good. We can always reconsider later if we want to make it an alias for datetime-local.

annevk added a commit that referenced this issue Nov 25, 2015
@annevk
Fix #336: remove <input type=datetime>
45f33b2
@annevk annevk closed this as completed in 80ba4fa Nov 26, 2015
@tkent-google
Copy link
Contributor Author

😄 Thanks!

@annevk
Copy link
Member

annevk commented Nov 26, 2015

Thank you for the suggestion!

@stuartpb
Copy link

stuartpb commented Dec 1, 2015

What's the new (existing) suggested best practice for unambiguous time point entry now? Have a datetime-local alongside a dropdown for picking the time zone?

@foolip
Copy link
Member

foolip commented Dec 1, 2015

That or an entirely custom component, I guess.

@domenic
Copy link
Member

domenic commented Dec 1, 2015

FWIW that's what Outlook does :)
timezone dropdown

@annevk
Copy link
Member

annevk commented Dec 7, 2015

Google Calendar does the same. Seems good enough.

@cvrebert cvrebert mentioned this issue Jan 2, 2016
Merged
cvrebert added a commit to twbs/bootstrap that referenced this issue Jan 6, 2016
@cvrebert
Remove usages of and references to <input type="datetime">
602b107 
It has been removed from the HTML specification: whatwg/html#336
Only Presto Opera ever implemented a special UI for it.

[skip sauce]
@cvrebert cvrebert mentioned this issue Jan 6, 2016
Merged
@eight04 eight04 mentioned this issue Jan 12, 2016
Closed
@rvklein
Copy link

rvklein commented Feb 10, 2016

Great, now we don't have a future option for unambiguous TZ datetime input. Thanks a lot.

@annevk
Copy link
Member

annevk commented Feb 11, 2016

I don't quite understand what you mean. Removal from the standard does not stop it from being introduced again at some point in the future.

@rvklein
Copy link

rvklein commented Feb 12, 2016

@annevk : It's likely my fault for misunderstanding the WHATWG process for these issues. Regardless, apologies for the sarcasm.

@annevk
Copy link
Member

annevk commented Feb 13, 2016

https://wiki.whatwg.org/wiki/FAQ#Is_there_a_process_for_removing_bad_ideas_from_a_specification.3F should explain the rationale. Basically, if something is not implemented and there is no desire to implement, we remove it. This happens at times. We've started being a lot more careful about adding new features though, so it should happen less going forward.

@morgoth morgoth mentioned this issue Mar 31, 2016
Merged
@leplatrem leplatrem mentioned this issue Apr 4, 2016
Merged
4 tasks
@cvrebert cvrebert mentioned this issue Apr 10, 2016
Closed
@eight04 eight04 mentioned this issue May 5, 2016
Closed
@obsidienne obsidienne mentioned this issue Jun 21, 2016
Closed
@kalebberry
Copy link

With datetime removed, this pretty much changes forums optimization a lot doesn't it? Its adding a another question or input. I am fine with this, but I don't see why to remove something useful.

bors-servo pushed a commit to servo/servo that referenced this issue Dec 7, 2017
Auto merge of #19509 - jonleighton:remove-input-type-datetime, r=jdm
8e3056d 
Remove support for <input type=datetime>

It has been removed from the spec: whatwg/html#336

See also #19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19509)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Dec 8, 2017
@jonleighton
servo: Merge #19509 - Remove support for <input type=datetime> (from …
c3439b7 
…jonleighton:remove-input-type-datetime); r=jdm

It has been removed from the spec: whatwg/html#336

See also servo/servo#19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e3056d0cc7caebc218d51373b3aa0ccd331fa20

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 76bd32c1d97be56bee2675857fcb5b20f2ed2d42
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this issue Dec 8, 2017
@jonleighton
servo: Merge #19509 - Remove support for <input type=datetime> (from …
dcfb744 
…jonleighton:remove-input-type-datetime); r=jdm

It has been removed from the spec: whatwg/html#336

See also servo/servo#19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e3056d0cc7caebc218d51373b3aa0ccd331fa20
chiraggmodi pushed a commit to chiraggmodi/bootstrap that referenced this issue Apr 8, 2019
@cvrebert @chiragatlas
Update iOS temporal input types support comment (twbs#20343)
9299012 
* <input type="datetime"> no longer exists, per whatwg/html#336
* iOS 9.3.2 still doesn't support <input type="week">

[skip sauce]
[skip validator]
@xfq xfq mentioned this issue Apr 9, 2019
Closed
Levure added a commit to Levure/symfony-docs that referenced this issue May 29, 2020
@Levure
Fix typo of HTML5 field type for DateTimeType
dd1749a 
Changed the html5 input type for DateTimeType to datetime-local (which is the html5 input type) instead of the datetime input type.

The datetime input type field has been removed from WHATWG HTML (whatwg/html#336)
The datetime-local input type is the type used for rendering DateTimeType when html5 option is set to true.
@Levure Levure mentioned this issue May 29, 2020
Merged
javiereguiluz added a commit to symfony/symfony-docs that referenced this issue May 29, 2020
@javiereguiluz
minor #13730 Fix typo of HTML5 field type for DateTimeType (Levure)
3eb5d73 
This PR was merged into the 3.4 branch.

Discussion
----------

Fix typo of HTML5 field type for DateTimeType

Changed the html5 input type for DateTimeType to datetime-local (which is the html5 input type) instead of the datetime input type.

- The **datetime** input type field has been removed from WHATWG HTML (whatwg/html#336)
- The **datetime-local** input type is the type used for rendering DateTimeType when html5 option is set to true.

Commits
-------

dd1749a Fix typo of HTML5 field type for DateTimeType
@github-actions github-actions bot mentioned this issue Apr 28, 2021
Merged
@github-actions github-actions bot mentioned this issue Sep 27, 2021
Merged
@github-actions github-actions bot mentioned this issue Oct 5, 2021
Merged
12 tasks
@wbamberg wbamberg mentioned this issue May 13, 2022
Merged
@github-actions github-actions bot mentioned this issue May 13, 2022
Merged
@github-actions github-actions bot mentioned this issue Jul 3, 2022
Merged
@github-actions github-actions bot mentioned this issue Jul 12, 2022
Merged
@github-actions github-actions bot mentioned this issue Jul 21, 2022
Closed
@github-actions github-actions bot mentioned this issue Aug 12, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 20, 2022
Merged
@github-actions github-actions bot mentioned this issue Oct 13, 2022
Merged
This was referenced Nov 1, 2022
Merged
Merged
This was referenced Nov 20, 2022
Merged
Merged
Merged
This was referenced Aug 2, 2023
Merged
Closed
This was referenced Aug 20, 2023
Closed
Merged
@bloatware bloatware mentioned this issue Nov 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project removal/deprecation Removing or deprecating a feature
Milestone
No milestone
Development

No branches or pull requests
8 participants
@zcorpan @foolip @stuartpb @domenic @annevk @kalebberry @rvklein @tkent-google