Fixes #114: Added a widget for datetime string format. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=? @magopian @leplatrem |
| onChange | ||
| }) { | ||
| return ( | ||
| <input type="datetime" |
There was a problem hiding this comment.
It looks like the right type is datetime-local.
See https://developer.mozilla.org/en/docs/Web/HTML/Element/Input#Attributes and whatwg/html#336
There was a problem hiding this comment.
Indeed, I'll update that.
|
r+wc :) |
n1k0
force-pushed
the
114-datetime-widget
branch
from
66a1226
to
ee548d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP. Refs #114 and #113. I've realized that the
stringJSONSchema type allows specifying aformatproperty, which can bedate-time. Previously, we were erroneously considering this value as a type, so this patch removes support for it as a type and moves its support as aformat.It also introduces a very basic
input[type=datetime]widget which offers a specific UI on some platforms; by default, browsers not supporting it will render a simple text input. The good thing being the validator works in every situation when validating the value, which must follow the RFC 3339, section 5.6 format.Note: next steps will be to add support for more string formats (email, url, etc.) through #113.