Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added useAllowance hook #1136

Closed
wants to merge 4 commits into from
Closed

Conversation

smakosh
Copy link

@smakosh smakosh commented Oct 22, 2022

Description

Added useAllowance hook to fetch the allowance of the owner/spender by token address

Additional Information

Your ENS/address: smakosh.eth

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2022

⚠️ No Changeset found

Latest commit: e80e033

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 22, 2022

@smakosh is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@smakosh
Copy link
Author

smakosh commented Oct 23, 2022

@tmm 👀

@smakosh
Copy link
Author

smakosh commented Oct 28, 2022

@jxom 👀 (we would love to use this in the next release and get rid of our own implementation, opened discussion before I started working on this and more to come: #1036)

@tmm
Copy link
Member

tmm commented Nov 1, 2022

Appreciate you looking into this! These type of hooks/actions (e.g. useAllowance/fetchAllowance) will be captured by an upcoming cli/codegen feature. This way, folks can bring ABIs, install plugins (e.g. ERC-20), etc. and generate code instead of increasing the surface area of wagmi.

@tmm tmm closed this Nov 1, 2022
@smakosh
Copy link
Author

smakosh commented Nov 1, 2022

You could have added this comment on the GH discussion 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants