Skip to content

Conversation

@jxom
Copy link
Member

@jxom jxom commented Nov 25, 2025

Fixes an issue where the nonce manager would unexpectedly consume a nonce if the eth_fillTransaction method is not supported.

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

🦋 Changeset detected

Latest commit: 56a5fbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/viem@4119

commit: d32fc12

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.41%. Comparing base (73f5e46) to head (56a5fbf).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/actions/wallet/prepareTransactionRequest.ts 84.21% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4119      +/-   ##
==========================================
+ Coverage   94.35%   94.41%   +0.06%     
==========================================
  Files        1083     1083              
  Lines        7931     7949      +18     
  Branches     2532     2545      +13     
==========================================
+ Hits         7483     7505      +22     
+ Misses        159      154       -5     
- Partials      289      290       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jxom jxom merged commit 9b89137 into main Nov 25, 2025
30 of 31 checks passed
@jxom jxom deleted the jxom/fill-tx-nonce-manager branch November 25, 2025 21:44
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants