Skip to content

Conversation

@jxom
Copy link
Member

@jxom jxom commented Nov 17, 2025

  • Adds a fillTransaction action that internally uses eth_fillTransaction.
  • Adds support for fillTransaction in prepareTransactionRequest, to reduce RPC network calls required to prepare a transaction from 3-4, to 1.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2025

🦋 Changeset detected

Latest commit: 8f7ca40

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom changed the title feat: support \eth_fillTransaction\ feat: support eth_fillTransaction Nov 17, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/viem@4098

commit: 8f7ca40

@jxom jxom force-pushed the jxom/fill-tx branch 2 times, most recently from fbf569a to 58e1134 Compare November 17, 2025 23:24
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 89.74359% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.43%. Comparing base (00325b0) to head (8f7ca40).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/actions/public/fillTransaction.ts 87.50% 3 Missing and 4 partials ⚠️
src/clients/decorators/wallet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4098      +/-   ##
==========================================
- Coverage   94.47%   94.43%   -0.04%     
==========================================
  Files        1079     1082       +3     
  Lines        7856     7926      +70     
  Branches     2505     2532      +27     
==========================================
+ Hits         7422     7485      +63     
- Misses        151      155       +4     
- Partials      283      286       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jxom jxom force-pushed the jxom/fill-tx branch 2 times, most recently from d33e8c7 to 3de19d4 Compare November 19, 2025 01:58
@jxom jxom marked this pull request as ready for review November 19, 2025 02:56
@jxom jxom merged commit 003b231 into main Nov 19, 2025
32 of 39 checks passed
@jxom jxom deleted the jxom/fill-tx branch November 19, 2025 03:02
@github-actions github-actions bot mentioned this pull request Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants