Conversation
|
| - `gasLimit`: use `eth_estimateGas` or its correspondent viem action.. | ||
| - `maxFeePerGas`: use `eth_gasPrice` or its correspondent viem action.. |
There was a problem hiding this comment.
Can we link to these Viem action doc pages?
| - `gasLimit`: use `eth_estimateGas` or its correspondent viem action.. | ||
| - `maxFeePerGas`: use `eth_gasPrice` or its correspondent viem action.. | ||
| - `maxPriorityFeePerGas`: set to `0`. | ||
| - `gasPerPubData`: use `zks_gasPerPubdata` or its correspondent viem action. |
There was a problem hiding this comment.
Should this PR add a Viem action for this? (So it can be linked to here.)
There was a problem hiding this comment.
Let's add the deprecation notice instead of deleting this page outright.
|
|
||
| export type GetTestnetPaymasterAddressReturnType = Address | null | ||
|
|
||
| /* @deprecated Check the ZKsync chain technical documentation to find the testnet paymaster address */ |
There was a problem hiding this comment.
Is there a link to the technical docs we can use here?
| /* @deprecated Check the ZKsync chain technical documentation to find the testnet paymaster address */ | |
| /* @deprecated Check the [ZKsync chain technical documentation](TODO) to find the testnet paymaster address */ |
There was a problem hiding this comment.
there's not really a single link for all, as this will depend if the dev is using ZKsync Era, Abstract, Sophon etc. Each ZKsync chain has its own. I'm updating the wording slightly to better reflect that.
There was a problem hiding this comment.
Let's keep this code during the deprecation period and we can remove in the next major version.
There was a problem hiding this comment.
Let's keep this code during the deprecation period and we can remove in the next major version.
| * | ||
| * const balances = await client.getAllBalances({account: "0x36615Cf349d7F6344891B1e7CA7C72883F5dc049"}); | ||
| */ | ||
| getAllBalances: ( |
There was a problem hiding this comment.
Add a @deprecated comment instead of removing.
There was a problem hiding this comment.
original code restored and added deprecation
There was a problem hiding this comment.
Let's keep this code during the deprecation period and we can remove in the next major version.
Co-authored-by: tmm <tom@meagher.co>
ZKsync has deprecated and announced the future deprecation of multiple RPC methods (see here and here)
Add deprecation warnings for method
getAllBalancesand its correspondent L2 actionAdds documentation for
getGasPerPubData, added in feat: add getGasPerPubdata action to usezks_gasPerPubdata#3817Updates docs to reflect upcoming RPC deprecated methods:
getMainContract
[x] docs deprecation warning
[x] down in sidebar
[x] add TS deprecation comment to the function
getBaseTokenL1Address
[x] docs deprecation warning
[x] down in sidebar
[x] add TS deprecation comment to the function
getL1ChainId
[x] docs deprecation warning
[x] down in sidebar
[x] add TS deprecation comment to the function
getTestnetPaymaster
[x] docs deprecation warning
[x] down in sidebar
[x] add TS deprecation comment to the function
estimateFee
[x] docs deprecation warning
[x] down in sidebar
[x] add TS deprecation comment to the function
getRawBlockTransactions
[x] docs deprecation warning
[x] down in sidebar
[x] add TS deprecation comment to the function