Skip to content

Comments

feat: remove webauthn-p256 in favor of Ox#3232

Merged
jxom merged 3 commits intomainfrom
remove-webauthn-p256
Jan 16, 2025
Merged

feat: remove webauthn-p256 in favor of Ox#3232
jxom merged 3 commits intomainfrom
remove-webauthn-p256

Conversation

@jxom
Copy link
Member

@jxom jxom commented Jan 15, 2025

No description provided.

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Jan 16, 2025 0:54am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
import * from 'viem' (esm) 63.96 KB (0%) 1.3 s (0%) 2.8 s (-54.73% 🔽) 4.1 s
const viem = require('viem') (cjs) 75.79 KB (0%) 1.6 s (0%) 9.3 s (+148.97% 🔺) 10.9 s
import { createClient, http } from 'viem' 6.33 KB (0%) 127 ms (0%) 822 ms (+101.49% 🔺) 948 ms
import * from 'viem/account-abstraction' 47.66 KB (0%) 954 ms (0%) 4.3 s (+44.36% 🔺) 5.2 s
import { toCoinbaseSmartAccount } from 'viem/account-abstraction' 36.13 KB (0%) 723 ms (0%) 4 s (+41.63% 🔺) 4.7 s
import * from 'viem/accounts' 82.41 KB (0%) 1.7 s (0%) 2.4 s (+46.51% 🔺) 4 s
import { privateKeyToAccount } from 'viem/accounts' 21.06 KB (0%) 422 ms (0%) 1.4 s (-23.61% 🔽) 1.8 s
import { mnemonicToAccount } from 'viem/accounts' 27.4 KB (0%) 549 ms (0%) 1.3 s (-48.15% 🔽) 1.8 s
import * from 'viem/actions' 49 KB (0%) 980 ms (0%) 4.1 s (+8.53% 🔺) 5.1 s
import { getBlockNumber } from 'viem/actions' 318 B (0%) 10 ms (0%) 59 ms (+361.91% 🔺) 69 ms
import * from 'viem/chains' 42.27 KB (0%) 846 ms (0%) 2.3 s (-28.33% 🔽) 3.1 s
import { mainnet } from 'viem/chains' 325 B (0%) 10 ms (0%) 43 ms (-79.7% 🔽) 53 ms
import * from 'viem/chains/utils' 1.08 KB (0%) 22 ms (0%) 86 ms (+221.83% 🔺) 108 ms
import * from 'viem/ens' 46.13 KB (0%) 923 ms (0%) 1.9 s (+11.54% 🔺) 2.8 s
import { getEnsAvatar } from 'viem/ens' 22.43 KB (0%) 449 ms (0%) 2.4 s (+22.24% 🔺) 2.9 s
import * from 'viem/siwe' 31.41 KB (0%) 629 ms (0%) 3 s (+3.88% 🔺) 3.6 s
import { verifySiweMessage } from 'viem/siwe' 30.39 KB (0%) 608 ms (0%) 3.4 s (+14% 🔺) 4 s

Co-Authored-By: Micah Zoltu <micah@zoltu.net>
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 10 lines in your changes missing coverage. Please review.

Project coverage is 99.61%. Comparing base (884f5ee) to head (4113b24).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t-abstraction/accounts/createWebAuthnCredential.ts 62.96% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
- Coverage   99.62%   99.61%   -0.01%     
==========================================
  Files         918      918              
  Lines       73454    73491      +37     
  Branches     3204     3203       -1     
==========================================
+ Hits        73177    73207      +30     
- Misses        258      265       +7     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom force-pushed the remove-webauthn-p256 branch from 8e134bc to 86c709c Compare January 16, 2025 00:17
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 4113b24

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom merged commit e1df486 into main Jan 16, 2025
12 of 13 checks passed
@jxom jxom deleted the remove-webauthn-p256 branch January 16, 2025 00:31
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant