finalizeWithdrawal: specify the proofSubmitter#3204
Merged
Conversation
🦋 Changeset detectedLatest commit: 13f1bee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@hamdiallam is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
reviewed
Jan 8, 2025
jxom
requested changes
Jan 8, 2025
Member
jxom
left a comment
There was a problem hiding this comment.
- Please rename from "submittor" to "submitter".
- Needs a changeset (
pnpm changeset) - Need to add
proofSubmitterto docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptimismPortal2 introduces
finalizeWithdrawalTransactionExternalProofsuch that the calling sender does not have to match the original proof submittor.With the current structure of the viem hook, the caller must be the proof submitter in order for the finalizing tx to succesfully execute
Introduce an optional
proofSubmittorargument to the simulating and executing hook forfinalizeWithdrawalTransaction. If set, use the the altered function. This introduces this functionality in a backwards compatible way.